Uh oh!
There was an error while loading. Please reload this page.
[stable30] fix(dav): file drop nickname - #53279
Merged
Merged
Conversation
skjnldsv
approved these changes
Jun 3, 2025
skjnldsv
requested review from
a team, artonge, nickvergessen, provokateurin and sorbaugh
and removed request for
a teamJune 3, 2025 08:08
| $isFileRequest = false; | ||
| $attributes = $this->share->getAttributes(); | ||
| $nickName = $request->hasHeader('X-NC-Nickname') ? urldecode($request->getHeader('X-NC-Nickname')) : null; | ||
| $nickName = $request->hasHeader('X-NC-Nickname') ? trim(urldecode($request->getHeader('X-NC-Nickname'))) : null; |
Check notice
Code scanning / Psalm
PossiblyNullArgument
Uh oh!
There was an error while loading. Please reload this page.
skjnldsvforce-pushed
the
backport/53278/stable30
branch
from
June 3, 2025 08:21
444c84c to
e38f9c6CompareUh oh!
There was an error while loading. Please reload this page.
provokateurin
approved these changes
Jun 3, 2025
skjnldsv
commented
Jun 3, 2025
Member
/compile |
nickvergessen
approved these changes
Jun 4, 2025
AndyScherzinger
enabled auto-merge
June 4, 2025 10:03
AndyScherzingerforce-pushed
the
backport/53278/stable30
branch
from
June 4, 2025 10:29
21353c9 to
0f1d737Compareskjnldsvforce-pushed
the
backport/53278/stable30
branch
3 times, most recently
from
June 5, 2025 07:01
c97718d to
71c9756Compareskjnldsv
commented
Jun 5, 2025
Member
/compile |
| // We need a valid nickname for file requests | ||
| if ($isFileRequest && ($nickName == null || trim($nickName) === '')) { | ||
| throw new MethodNotAllowed('Nickname is required for file requests'); | ||
| if ($isFileRequest && !$nickName) { |
Check notice
Code scanning / Psalm
RiskyTruthyFalsyComparison
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsvforce-pushed
the
backport/53278/stable30
branch
from
June 5, 2025 07:58
5cfa427 to
04b5d37Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #53278