Uh oh!
There was an error while loading. Please reload this page.
fix(notifications): Fix check for hasNotifiers when all apps use Regi… - #53314
Merged
Conversation
…strationContext Signed-off-by: Joas Schilling <coding@schilljs.com>
provokateurin
approved these changes
Jun 4, 2025
SystemKeeper
approved these changes
Jun 4, 2025
nickvergessen
commented
Jun 6, 2025
MemberAuthor
/backport to stable31 |
nickvergessen
commented
Jun 6, 2025
MemberAuthor
/backport to stable30 |
This was referenced Jun 6, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…strationContext
IBootstrap#53157 which removed the last non-RegistrationContext registered Notifier that was always there. After that pull request there was never a direct one and the RegistrationContext was not yet tested whether it really has any notifiers. This causedhasNotifiers()to return false even though it had notifiers later on when actually getting them. But the notifications app did an early exit with a better status code when non notifier exists.Checklist