Uh oh!
There was an error while loading. Please reload this page.
fix: Set public link upload email notification to opt-in - #53322
Merged
Conversation
GretaD
approved these changes
Jun 16, 2025
This now sets `isDefaultEnabled` to false. This makes email notifications for file uploads to public links disabled by default (opt-in) for users. This addresses concerns about new notifications being enabled by default for existing users, leading to unexpected emails. Related: #46945 Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebeforce-pushed
the
fix/public-upload-notification-default
branch
from
June 17, 2025 12:57
cebbbfc to
1f8a230Comparenfebe
enabled auto-merge
June 17, 2025 12:57
susnux
approved these changes
Jun 17, 2025
AndyScherzinger
approved these changes
Jun 17, 2025
nfebe
commented
Jun 17, 2025
ContributorAuthor
backport to stable31 |
nfebe
commented
Jun 17, 2025
ContributorAuthor
/backport to stable31 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This now sets
isDefaultEnabledto false. This makes email notifications for file uploads to public links disabled by default (opt-in) for users.This addresses concerns about new notifications being enabled by default for existing users, leading to unexpected emails.
Related: #46945