Uh oh!
There was an error while loading. Please reload this page.
[stable31] fix(settings): show group label instead of gid in accounts management - #53411
Merged
Conversation
skjnldsv
approved these changes
Jun 10, 2025
susnux
approved these changes
Jun 10, 2025
AndyScherzinger
approved these changes
Jun 10, 2025
susnux
reviewed
Jun 11, 2025
| .map(group => { | ||
| // Try to match with more extensive group data | ||
| const availableGroup = this.availableSubAdminGroups.find(g => g.id === group.id) | ||
| return availableGroup.name ?? group.name ?? group.id |
Contributor
There was a problem hiding this comment.
Suggested change
| return availableGroup.name ?? group.name ?? group.id | |
| return availableGroup?.name ?? group.name ?? group.id |
susnux
reviewed
Jun 11, 2025
| .map(group => { | ||
| // Try to match with more extensive group data | ||
| const availableGroup = this.availableGroups.find(g => g.id === group.id) | ||
| return availableGroup.name ?? group.name ?? group.id |
Contributor
There was a problem hiding this comment.
Suggested change
| return availableGroup.name ?? group.name ?? group.id | |
| return availableGroup?.name ?? group.name ?? group.id |
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsvforce-pushed
the
backport/53363/stable31
branch
from
June 12, 2025 19:19
77060dd to
dc59cfcCompareSigned-off-by: skjnldsv <skjnldsv@protonmail.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
skjnldsv
commented
Jun 12, 2025
Member
/compile |
skjnldsvforce-pushed
the
backport/53363/stable31
branch
from
June 12, 2025 20:02
461b1a9 to
3d2c00aCompareSigned-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #53363
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.