Skip to content

fix(tests): Fix 32bits PHPUnit tests - #53417

Merged
come-nc merged 4 commits into
masterfrom
fix/fix-32bits-phpunit
Jun 19, 2025
Merged

fix(tests): Fix 32bits PHPUnit tests#53417
come-nc merged 4 commits into
masterfrom
fix/fix-32bits-phpunit

Conversation

@come-nc

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

Follow-up of #48210 which broke 32bit testing in CI

Checklist

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nccome-nc self-assigned this Jun 10, 2025
@come-nc
come-nc requested a review from a team as a code ownerJune 10, 2025 09:03
@come-nccome-nc added the 2. developing Work in progress label Jun 10, 2025
@come-nc
come-nc requested review from Altahrim, ArtificialOwl and leftybournes and removed request for a teamJune 10, 2025 09:03
Also add output when enabling applications, and watch phpunit
configuration file for changes.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Simply let the Exception bubble up instead of caching it and using grep
to then detect it.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
come-ncforce-pushed the fix/fix-32bits-phpunit branch from 998afb4 to b1f6283CompareJune 10, 2025 13:39
@come-nccome-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 10, 2025
@come-nccome-nc added this to the Nextcloud 32 milestone Jun 10, 2025
with:
php-version: ${{ matrix.php-versions }}
extensions: ctype, curl, dom, fileinfo, gd, imagick, intl, json, mbstring, openssl, pdo_sqlite, posix, sqlite, xml, zip, apcu
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, imagick, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite, apcu, ldap

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apcu, bz2, ctype, curl, dom, fileinfo, gd, iconv, imagick, intl, json, ldap, libxml, mbstring, openssl, pcntl, pdo_sqlite, posix, redis, session, simplexml, sqlite, xmlreader, xmlwriter, zip, zlib

I would love to have the list sorted 🙈

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but I reused the order of the other jobs to have it easier to compare.
It’s a mystery to me why no other job have the ldap module though, is php-32bit the only CI running user_ldap tests?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ldap module could be enabled by default though.

@blizzzblizzzJun 19, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately phpunit warnings and skipped tests are not printed

Update: but rather integration tests and they run and ldap is enabled, e.g.: https://github.com/nextcloud/server/actions/runs/15561112793

@come-nc
come-nc merged commit 12524d9 into masterJun 19, 2025
@come-nc
come-nc deleted the fix/fix-32bits-phpunit branch June 19, 2025 08:38
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@come-nc@st3iny@blizzz@kesselb@skjnldsv