fix: make Rotate a TimedJob and run every hour

[salmart-dev]

Summary

This PR is a follow-up to address issues discovered while investigating issue #49584

When running occ background-job:worker, some jobs can be seen running constantly and Rotate is one of them. It should be safe to run the rotation job every 5 seconds.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[salmart-dev]

@come-nc the job is now set to run every hour

[salmart-dev]

In the last force-push I removed the "Merge into master" commit, which I created when clicking on the GitHub UI to update the branch instead of hitting rebase.

[salmart-dev]

@come-nc should I backport this to 30 and 31?

[Altahrim]

You may need to adjust PR title :)

[salmart-dev]

/backport 30

[salmart-dev]

/backport stable30

[salmart-dev]

/backport to stable30

[salmart-dev]

/backport to stable31

[joshtrichards]

Maybe we should eliminate this magic number (stick in in RotationTrait?) and then also use it elsewhere and keep rotation consistent across the board:

server/apps/admin_audit/lib/BackgroundJobs/Rotate.php

Line 24 in ec73f4a

$this->setInterval(60 * 60 * 3);

server/apps/workflowengine/lib/BackgroundJobs/Rotate.php

Line 20 in ec73f4a

$this->setInterval(60 * 60 * 3);

[come-nc]

Why not, but let’s not delay this PR any longer for this. It can be done later.

[nickvergessen]

But what if a 1h junk is much bigger than the configured limit?
previously it ran on every execution?

[salmart-dev]

@nickvergessen we discussed this here #53420 (comment) and concluded to set it to 1h, could you check with Côme or Benjamin?

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)