Uh oh!
There was an error while loading. Please reload this page.
fix(files_sharing): Hide link shares for users in excluded groups - #53466
Merged
Conversation
nfebeforce-pushed
the
feature/hide-external-shares-excluded-groups
branch
2 times, most recently
from
June 17, 2025 09:06
137152b to
1e8112cComparenfebe
commented
Jun 17, 2025
ContributorAuthor
Should this apply to emails as well? |
nfebe
marked this pull request as ready for review
June 17, 2025 09:07
nfebe
requested review from
artonge, marcoambrosini, skjnldsv, sorbaugh and susnux
and removed request for
a team, artonge and skjnldsvJune 17, 2025 09:07
nfebeforce-pushed
the
feature/hide-external-shares-excluded-groups
branch
2 times, most recently
from
June 17, 2025 09:10
cccdaf9 to
37b7486CompareAndyScherzinger
approved these changes
Jun 17, 2025
nfebeforce-pushed
the
feature/hide-external-shares-excluded-groups
branch
from
June 17, 2025 09:25
b4e9c0e to
23e44f1Comparejancborchardt
approved these changes
Jun 17, 2025
jancborchardt
left a comment
Member
There was a problem hiding this comment.
@nfebe since the setting is called "Allow users to share via link and emails", exclusion should apply to both link and email. :)
marcoambrosini
approved these changes
Jun 17, 2025
nfebeforce-pushed
the
feature/hide-external-shares-excluded-groups
branch
from
June 17, 2025 13:30
23e44f1 to
595df96Comparenfebe
commented
Jun 17, 2025
nfebe
left a comment
ContributorAuthor
There was a problem hiding this comment.
Prevents both emails and link shares now.
| }, | ||
| externalShareInputPlaceholder() { | ||
| if (!this.isLinkSharingAllowed) { |
ContributorAuthor
There was a problem hiding this comment.
This was already handled in the SharingInput and now the text updated to match so all good now.
- Added frontend check to hide link shares if, public sharing is disabled. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebeforce-pushed
the
feature/hide-external-shares-excluded-groups
branch
from
June 17, 2025 13:33
595df96 to
57f3edcComparenfebe
enabled auto-merge
June 17, 2025 13:33
nfebe
commented
Jun 17, 2025
ContributorAuthor
/compile |
nfebe
commented
Jun 17, 2025
ContributorAuthor
/backport to stable31 |
nfebe
commented
Jun 17, 2025
ContributorAuthor
/backport to stable30 |
nfebeforce-pushed
the
feature/hide-external-shares-excluded-groups
branch
3 times, most recently
from
June 17, 2025 17:35
7a9a58e to
edb7fecCompareSigned-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nfebeforce-pushed
the
feature/hide-external-shares-excluded-groups
branch
from
June 17, 2025 18:30
edb7fec to
9583a67Compare
This was referenced Jun 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excluded groups should not see the create link share option in UI?