Skip to content

[files_versions] Fix sidebar version item style - #53512

Merged
tcitworld merged 2 commits into
masterfrom
fix/noid/files-version-sidebar-item-style
Jun 18, 2025
Merged

[files_versions] Fix sidebar version item style#53512
tcitworld merged 2 commits into
masterfrom
fix/noid/files-version-sidebar-item-style

Conversation

@julien-nc

@julien-ncjulien-nc commented Jun 16, 2025

Copy link
Copy Markdown
Member

Give the version label a min width so it does not get invisible when the author name is long.
Make sure the overflow ofboth version label and author name are ellispsised.

Before

image

After

image

@julien-ncjulien-nc added this to the Nextcloud 32 milestone Jun 16, 2025
@julien-nc
julien-nc requested a review from a team as a code ownerJune 16, 2025 12:53
@julien-ncjulien-nc added bug 3. to review Waiting for reviews labels Jun 16, 2025
@julien-nc
julien-nc requested review from artonge and nfebe and removed request for a teamJune 16, 2025 12:53
@julien-nc
julien-nc requested a review from sorbaughJune 16, 2025 12:53
@julien-nc

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@julien-nc

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@julien-nc

Copy link
Copy Markdown
MemberAuthor

/compile

@nextcloud-command
nextcloud-command requested a review from a team as a code ownerJune 16, 2025 13:59
@tcitworld

Copy link
Copy Markdown
Member

Why not give it enough space for « Current version » to be shown entirely?

@julien-nc

Copy link
Copy Markdown
MemberAuthor

@tcitworld No reason. Anyway many translations of this string are longer and will be cut.
I can make it larger indeed. Waiting for more opinions.

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise ok, I would indeed make the label flex-grow with a max-width :)

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nextcloud/designers can you give us your opinion?

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice @julien-nc! :)

Why not give it enough space for « Current version » to be shown entirely?

Agree with @tcitworld’s point – since the 100px width is an arbitrary value anyway, it might as well be a little bit wider so that our default texts are shown fully, at least in English. :)

…t get invisible if the author name is long
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
julien-ncforce-pushed the fix/noid/files-version-sidebar-item-style branch from abe85ad to 422e3d9CompareJune 18, 2025 09:47
@julien-nc

Copy link
Copy Markdown
MemberAuthor

/compile

@julien-nc

Copy link
Copy Markdown
MemberAuthor

@jancborchardt Changed the min-width and updated the screenshot.

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@tcitworld
tcitworld merged commit 367a585 into masterJun 18, 2025
@tcitworld
tcitworld deleted the fix/noid/files-version-sidebar-item-style branch June 18, 2025 11:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@julien-nc@tcitworld@jancborchardt@artonge@skjnldsv@nextcloud-command