Skip to content

fix(files_reminders): Join the reminders with the file system metadata - #53548

Merged
come-nc merged 1 commit into
masterfrom
fixFilesRemindersJoins
Jun 23, 2025
Merged

fix(files_reminders): Join the reminders with the file system metadata#53548
come-nc merged 1 commit into
masterfrom
fixFilesRemindersJoins

Conversation

@solracsf

@solracsfsolracsf commented Jun 17, 2025•
edited by provokateurin
Loading

Copy link
Copy Markdown
Member

Eliminates the need to load fileIds into PHP by using a database INNER JOIN with the oc_filecache table, filtering files by their parent (the folder's ID) directly in the SQL query. This avoids the IN clause entirely

Checklist

@solracsf
fix(files_reminders): Join the reminders with the file system metadat…
4eb357e
…a table
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsfsolracsf added the 2. developing Work in progress label Jun 17, 2025
@solracsfsolracsf mentioned this pull request Jun 17, 2025
Closed
8 tasks
provokateurin
provokateurin approved these changes Jun 23, 2025
View reviewed changes

@provokateurinprovokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks much better and should fix #53527

@provokateurin

provokateurin commented Jun 23, 2025

Copy link
Copy Markdown
Member

@solracsf any reason to keep it as a draft?

@solracsf

This comment was marked as resolved.

Sign in to view
@provokateurin
provokateurin marked this pull request as ready for review June 23, 2025 07:48
@provokateurin
provokateurin requested a review from a team as a code ownerJune 23, 2025 07:48
@provokateurin
provokateurin requested review from Altahrim, ArtificialOwl and icewind1991 and removed request for a teamJune 23, 2025 07:48
@provokateurin

provokateurin commented Jun 23, 2025

Copy link
Copy Markdown
Member

/backport to stable31

@provokateurin

This comment was marked as resolved.

Sign in to view
@come-nc
come-nc merged commit f980d94 into masterJun 23, 2025
@come-nc
come-nc deleted the fixFilesRemindersJoins branch June 23, 2025 10:24
@backportbot

This comment was marked as outdated.

Sign in to view
@backportbotbackportbotBot mentioned this pull request Jun 23, 2025
Merged
kesselb
kesselb reviewed Jun 23, 2025
View reviewed changes
Comment threadapps/files_reminders/lib/Db/ReminderMapper.php
@kesselbkesselb mentioned this pull request Jun 23, 2025
Merged
4 tasks
@provokateurin

provokateurin commented Jun 23, 2025

Copy link
Copy Markdown
Member

The stable30 backport must also include #53644!

@solracsf

solracsf commented Jun 23, 2025

Copy link
Copy Markdown
MemberAuthor

The stable30 backport must also include #53644!

findAllInFolder() is v31+

@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbkesselb left review comments
@provokateurinprovokateurinprovokateurin approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
@susnuxsusnuxAwaiting requested review from susnux

Assignees

No one assigned

Labels

2. developingWork in progressbackport-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: More than 1000 expressions in a list are not allowed on Oracle. (postgresql, in files_reminders / cacheFolder)

4 participants

@solracsf@provokateurin@kesselb@come-nc