Skip to content

fix(files): add plural form for selected nodes - #53567

Merged
susnux merged 2 commits into
masterfrom
fix/files-plural
Jun 18, 2025
Merged

fix(files): add plural form for selected nodes#53567
susnux merged 2 commits into
masterfrom
fix/files-plural

Conversation

@susnux

@susnuxsusnux commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

Summary

Reported at Transifex:

This string needs pluralization feature, because in some languages translation of "selected" differs between singular and plural.

Checklist

@susnuxsusnux added this to the Nextcloud 32 milestone Jun 18, 2025
@susnux
susnux requested a review from rakeknivenJune 18, 2025 08:22
@susnux
susnux requested review from a team and skjnldsv as code ownersJune 18, 2025 08:22
@susnuxsusnux added the bug label Jun 18, 2025
@susnux
susnux requested review from artonge and sorbaugh and removed request for a teamJune 18, 2025 08:22
@susnuxsusnux added 3. to review Waiting for reviews feature: files labels Jun 18, 2025
@susnux

susnux commented Jun 18, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

@susnux

susnux commented Jun 18, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

artonge
artonge reviewed Jun 18, 2025
View reviewed changes

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't the singular and plural strings the same?

artonge
artonge approved these changes Jun 18, 2025
View reviewed changes

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just saw the issue, maybe add a comment above

@susnux

susnux commented Jun 18, 2025

Copy link
Copy Markdown
ContributorAuthor

/compile

@nextcloud-command
nextcloud-command requested a review from a team as a code ownerJune 18, 2025 11:05
@susnux

susnux commented Jun 18, 2025

Copy link
Copy Markdown
ContributorAuthor

/compile

susnuxand others added 2 commits June 18, 2025 18:16
@susnux
fix(files): add plural form for selected nodes
3796c96
Reported at Transifex:
> This string needs pluralization feature, because in some languages translation of "selected" differs between singular and plural.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@nextcloud-command@susnux
chore(assets): Recompile assets
f5fd649
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnux merged commit da7a902 into masterJun 18, 2025
@susnux
susnux deleted the fix/files-plural branch June 18, 2025 17:58
This was referenced Jun 18, 2025
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakeknivenrakeknivenrakekniven approved these changes
@artongeartongeartonge approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: files

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

i18n: Plural form in vue file needed

5 participants

@susnux@rakekniven@artonge@skjnldsv@nextcloud-command