Uh oh!
There was an error while loading. Please reload this page.
fix(files_sharing): do not double escape the share title - #53590
Merged
Conversation
susnux
commented
Jun 18, 2025
ContributorAuthor
/backport to stable31 |
susnux
commented
Jun 18, 2025
ContributorAuthor
/backport to stable30 |
szaimen
removed their request for review
June 18, 2025 18:08
AndyScherzinger
approved these changes
Jun 18, 2025
skjnldsv
approved these changes
Jun 19, 2025
AndyScherzingerforce-pushed
the
fix/files-sharing-label
branch
from
June 19, 2025 07:38
3f49f80 to
9ae4435CompareAndyScherzinger
commented
Jun 19, 2025
Member
/compile |
The title is already escaped by vue so special characters would result in incorrect strings. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnuxforce-pushed
the
fix/files-sharing-label
branch
from
June 19, 2025 10:42
46ece52 to
192a123CompareThe backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/53590/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 87428bfe 192a1236
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/53590/stable30Error: Failed to push branch backport/53590/stable30: remote: Invalid username or password. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The title is already escaped by vue so special characters would result in incorrect strings.
Checklist