Uh oh!
There was an error while loading. Please reload this page.
fix: don't scan the same storage multiple times - #53647
Merged
Merged
Conversation
icewind1991
requested review from
artonge, provokateurin and yemkareems
and removed request for
a teamJune 23, 2025 14:26
provokateurin
approved these changes
Jun 23, 2025
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
dont-double-scan-storage
branch
from
June 24, 2025 14:27
e8317bc to
a338f56CompareAndyScherzinger
approved these changes
Jun 24, 2025
provokateurin
commented
Jun 24, 2025
Member
Backport? @icewind1991 |
icewind1991
commented
Jun 25, 2025
MemberAuthor
/backport to stable31 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When scanning multiple users, the scanner might encounter the same storage multiple times (e.g. external storages, or group folders).
This adds a check to filter out any storage we've already scanned to avoid double work.