Skip to content

fix: don't try to get fileid for non exising nodes when serializing events file - #53648

Merged
susnux merged 1 commit into
masterfrom
rename-hooks-webhook
Jul 1, 2025
Merged

fix: don't try to get fileid for non exising nodes when serializing events file#53648
susnux merged 1 commit into
masterfrom
rename-hooks-webhook

Conversation

@icewind1991

Copy link
Copy Markdown
Member

This fixes listening to BeforeNodeRenamedEvent and NodeRenamedEvent with webhooks.

Fixes#50938

@icewind1991icewind1991 added this to the Nextcloud 32 milestone Jun 23, 2025
@icewind1991
icewind1991 requested a review from a team as a code ownerJune 23, 2025 15:40
@icewind1991
icewind1991 requested review from come-nc, nfebe and skjnldsv and removed request for a teamJune 23, 2025 15:40
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Jun 23, 2025
@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@come-nccome-nc added the pending documentation This pull request needs an associated documentation update label Jun 24, 2025
@icewind1991
icewind1991force-pushed the rename-hooks-webhook branch from e1992e8 to 3df2d05CompareJune 24, 2025 17:09
…vents file
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the rename-hooks-webhook branch from 3df2d05 to ab6f418CompareJune 27, 2025 18:52
@susnux
susnux merged commit dd92b45 into masterJul 1, 2025
@susnux
susnux deleted the rename-hooks-webhook branch July 1, 2025 12:23
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
joshtrichards added a commit to nextcloud/documentation that referenced this pull request Nov 11, 2025
Updated the webhook listeners documentation for clarity and consistency, including corrections to event descriptions and examples.
Fixes:
- nextcloud/server#56371
- nextcloud/server#53648 (review)
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards

Copy link
Copy Markdown
Member

Doc update PR pending in nextcloud/documentation#13853

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewspending documentationThis pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request to Include "Rename" and "Move" Events in Webhook Notifications

6 participants

@icewind1991@joshtrichards@skjnldsv@come-nc@susnux@tobiasKaminsky