Skip to content

Better error message on invalid sharing link - #5367

Merged
MorrisJobke merged 1 commit into
masterfrom
better-share-error
Jun 13, 2017
Merged

Better error message on invalid sharing link#5367
MorrisJobke merged 1 commit into
masterfrom
better-share-error

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jun 13, 2017

Copy link
Copy Markdown
Member

@nickvergessennickvergessen added this to the Nextcloud 13 milestone Jun 13, 2017
LukasReschke
LukasReschke requested changes Jun 13, 2017
View reviewed changes

@LukasReschkeLukasReschke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing now 🙈

@nextcloudnextcloud deleted a comment from codecovBotJun 13, 2017
@nickvergessen

nickvergessen commented Jun 13, 2017

Copy link
Copy Markdown
MemberAuthor

👍 thanks

@nickvergessen
Fix unknown share token
0f8c1b1
Signed-off-by: Joas Schilling <coding@schilljs.com>
@codecov

codecovBot commented Jun 13, 2017

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@906b240). Click here to learn what that means.
The diff coverage is 0%.

@@ Coverage Diff @@## master #5367 +/- ##
=========================================
Coverage ? 31.27% Complexity ? 22311 =========================================
Files ? 1381 Lines ? 84861 Branches ? 1325 =========================================
Hits ? 26543 Misses ? 58318 Partials ? 0
Impacted FilesCoverage ΔComplexity Δ
lib/private/Share20/ProviderFactory.php0% <0%> (ø)29 <0> (?)
lib/private/Share20/DefaultShareProvider.php0% <0%> (ø)114 <0> (?)

MorrisJobke
MorrisJobke approved these changes Jun 13, 2017
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish backport-request and removed 3. to review Waiting for reviews labels Jun 13, 2017
@nickvergessennickvergessen mentioned this pull request Jun 13, 2017
Merged
@nickvergessen

nickvergessen commented Jun 13, 2017

Copy link
Copy Markdown
MemberAuthor

Backport in #5387

@MorrisJobke
MorrisJobke merged commit 101d1c0 into masterJun 13, 2017
@MorrisJobke
MorrisJobke deleted the better-share-error branch June 13, 2017 19:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@LukasReschkeLukasReschkeLukasReschke approved these changes
@schiessleschiessleAwaiting requested review from schiessle

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: sharing

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@MorrisJobke@LukasReschke