Uh oh!
There was an error while loading. Please reload this page.
fix(dav): catch exception on non local account - #53677
Merged
Merged
Conversation
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
requested review from
Altahrim, artonge and skjnldsv
and removed request for
a teamJune 25, 2025 12:37
ArtificialOwl
commented
Jun 25, 2025
MemberAuthor
/backport to stable31 |
ArtificialOwl
commented
Jun 25, 2025
MemberAuthor
/backport to stable30 |
Altahrim
approved these changes
Jun 25, 2025
provokateurin
approved these changes
Jun 25, 2025
| // Check if the user published their display name | ||
| $ownerAccount = $this->accountManager->getAccount($owner); | ||
| try { | ||
| $ownerAccount = $this->accountManager->getAccount($owner); |
Contributor
There was a problem hiding this comment.
I am checking the code executed by getAccount but I can't find a place that throws the NoUserException (yet).
What I see is that inside this function, there is a call to getUser with default arguments, one of which is $insertIfNotExists = true. Doesn't this mean that if the user is not local, it gets created? Is that ok?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix a regression from #52535 blocking public link on federated shares.