Skip to content

[stable29] perf(dav): Preload dav search with tags/favorites - #53774

Merged
AndyScherzinger merged 1 commit into
stable29from
backport/53773/stable29
Jul 7, 2025
Merged

[stable29] perf(dav): Preload dav search with tags/favorites#53774
AndyScherzinger merged 1 commit into
stable29from
backport/53773/stable29

Conversation

@backportbot

@backportbotbackportbotBot commented Jul 2, 2025

Copy link
Copy Markdown

Backport of #53773

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@blizzzblizzz changed the title [stable29] [stable30] perf(dav): Preload dav search with tags/favorites[stable29] perf(dav): Preload dav search with tags/favoritesJul 2, 2025
@blizzz
blizzzforce-pushed the backport/53773/stable29 branch from 4077493 to 48335f9CompareJuly 2, 2025 21:46
@blizzz
blizzz marked this pull request as ready for review July 2, 2025 21:46
@AndyScherzinger

Copy link
Copy Markdown
Member

@blizzz commit has skip ci line in it.

) {
return;
}
$this->prefetchTagsForFileIds(array_map(fn ($node) => $node->getId(), $nodes));

Check notice

Code scanning / Psalm

MissingClosureReturnType Note

Closure does not have a return type, expecting mixed
@blizzz
blizzzforce-pushed the backport/53773/stable29 branch from f4e1181 to bd8e530CompareJuly 3, 2025 09:28
// note: pre-fetching only supported for depth <= 1
$folderContent = $node->getChildren();
$fileIds[] = (int)$node->getId();
$fileIds = [(int)$node->getId()];

Check notice

Code scanning / Psalm

RedundantCastGivenDocblockType Note

Redundant cast to int given docblock-provided type
@blizzz
blizzzforce-pushed the backport/53773/stable29 branch from bd8e530 to c2b8311CompareJuly 3, 2025 09:37
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@blizzz
blizzzforce-pushed the backport/53773/stable29 branch from c2b8311 to 855d455CompareJuly 7, 2025 18:10
@AndyScherzinger
AndyScherzinger merged commit c0c3d6e into stable29Jul 7, 2025
185 of 198 checks passed
@AndyScherzinger
AndyScherzinger deleted the backport/53773/stable29 branch July 7, 2025 18:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@AndyScherzinger@blizzz@skjnldsv@github-advanced-security@juliusknorr