Skip to content

Fix #5349, no themed icon when dragging folder - #5378

Merged
MorrisJobke merged 1 commit into
nextcloud:masterfrom
patschi:fix-5349
Jun 13, 2017
Merged

Fix #5349, no themed icon when dragging folder#5378
MorrisJobke merged 1 commit into
nextcloud:masterfrom
patschi:fix-5349

Conversation

@patschi

@patschipatschi commented Jun 13, 2017

Copy link
Copy Markdown
Member

Fixes#5349. Working again:
image

Signed-off-by: Patrik Kernstock <info@pkern.at>
@patschipatschi added 3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: theming labels Jun 13, 2017
@mention-bot

Copy link
Copy Markdown

@patschi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @MorrisJobke and @ErikPel to be potential reviewers.

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works 🚀

@MorrisJobkeMorrisJobke added this to the Nextcloud 13 milestone Jun 13, 2017
@MorrisJobke

Copy link
Copy Markdown
Member

CI failure is the already fixed auth app. Merge

@MorrisJobke
MorrisJobke merged commit eafaa2f into nextcloud:masterJun 13, 2017
@MorrisJobke

Copy link
Copy Markdown
Member

@karlitschek I would say we should backport this at least to stable12 to have proper theming also available for the not that common use cases. 😉

@MorrisJobke

Copy link
Copy Markdown
Member

Backport in #5388

@karlitschek

Copy link
Copy Markdown
Member

makes sense 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.feature: theming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@patschi@mention-bot@MorrisJobke@karlitschek@LukasReschke