Uh oh!
There was an error while loading. Please reload this page.
fix(files_sharing): restore state when updating share failed - #54055
Merged
Conversation
susnux
commented
Jul 23, 2025
ContributorAuthor
/backport to stable31 |
susnux
commented
Jul 23, 2025
ContributorAuthor
/backport to stable30 |
susnux
requested review from
leftybournes and nfebe
and removed request for
artongeJuly 23, 2025 11:01
susnuxforce-pushed
the
fix/sharing-restore-on-failure
branch
from
July 23, 2025 11:56
3dcfc18 to
a0ffce8Comparesusnux
commented
Jul 23, 2025
ContributorAuthor
/compile |
skjnldsv
approved these changes
Jul 23, 2025
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Code make sense, did not test though
provokateurin
approved these changes
Jul 23, 2025
We need to save the previous state - here the password - so that if the update fails we can revert the shown state. This happens e.g. if you have the password policy app and try to add an unsecure password. To reproduce (with password policy): 1. Create new link share 2. enable password protection 3. use insecure password like `1234` 4. save share Now you see that the update failed, but the password protection is still enabled. This happened because `password` and `newPassword` were misused. `password` was already set when `newPassword` was not saved so we could not know to what we need to reset when the update failed. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnuxforce-pushed
the
fix/sharing-restore-on-failure
branch
from
July 23, 2025 15:07
cfbdd96 to
1fbce91CompareUh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 23, 2025
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We need to save the previous state - here the password - so that if the update fails we can revert the shown state.
This happens e.g. if you have the password policy app and try to add an insecure password.
To reproduce (with password policy):
1234Now you see that the update failed, but the password protection is still enabled. This happened because
passwordandnewPasswordwere misused.passwordwas already set whennewPasswordwas not saved so we could not know to what we need to reset when the update failed.Checklist