Skip to content

fix: Ensure CLOUD key exists before resolving Cloud ID - #54102

Merged
artonge merged 1 commit into
masterfrom
ensure-cloud-key
Oct 17, 2025
Merged

fix: Ensure CLOUD key exists before resolving Cloud ID#54102
artonge merged 1 commit into
masterfrom
ensure-cloud-key

Conversation

@enjeck

@enjeckenjeck commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

Summary

When the Nextcloud server is configured to use an LDAP server whose users are synchronized with the system address book, any user search for sharing a conversation (spreed), a calendar (calendar), or a board (deck) generates exceptions of the form:

"Exception: Argument 1 passed to OC\Federation\CloudIdManager::resolveCloudId() must be of the type string, null given, called in /var/www/nextcloud/lib/private/Collaboration/Collaborators/MailPlugin.php on line 185 in file '/var/www/nextcloud/lib/private/Federation/CloudIdManager.php' line 58"
"Error: Trying to access array offset on value of type null at /var/www/nextcloud/lib/private/Collaboration/Collaborators/MailPlugin.php#185"
"Error: Undefined index: CLOUD at /var/www/nextcloud/lib/private/Collaboration/Collaborators/MailPlugin.php#185"

The line number generating the exception may differ from one Nextcloud version to another.
Each exception is linked to a contact from LDAP. If the search results only contain manually created contacts (present in a personal address book), there are no exceptions.

Checklist

@enjeckenjeck self-assigned this Jul 28, 2025
@enjeck
enjeck requested a review from a team as a code ownerJuly 28, 2025 05:37
@enjeck
enjeck requested review from artonge, leftybournes and salmart-dev and removed request for a teamJuly 28, 2025 05:37
@solracsfsolracsf added the 3. to review Waiting for reviews label Aug 6, 2025
@solracsfsolracsf added this to the Nextcloud 32 milestone Aug 6, 2025
@nextcloud-botnextcloud-bot mentioned this pull request Aug 22, 2025
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
@nextcloud-botnextcloud-bot mentioned this pull request Aug 25, 2025
@nextcloud-botnextcloud-bot mentioned this pull request Aug 28, 2025
This was referenced Sep 2, 2025
@nextcloud-botnextcloud-bot mentioned this pull request Sep 10, 2025
@nextcloud-botnextcloud-bot mentioned this pull request Sep 18, 2025
This was referenced Sep 25, 2025
@artonge
artonge merged commit 77194d5 into masterOct 17, 2025
198 checks passed
@artonge
artonge deleted the ensure-cloud-key branch October 17, 2025 16:21
@maximelehericy

Copy link
Copy Markdown

@come-nc any chances to see that backported to 31 ?

@come-nc

Copy link
Copy Markdown
Contributor

/backport to stable32

@come-nc

Copy link
Copy Markdown
Contributor

/backport to stable31

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@enjeck@maximelehericy@come-nc@artonge@solracsf@skjnldsv