Skip to content

feat(activity): add bulk activity option - #54117

Merged
miaulalala merged 1 commit into
masterfrom
feat/noid/add-bulk-activity
Aug 14, 2025
Merged

feat(activity): add bulk activity option#54117
miaulalala merged 1 commit into
masterfrom
feat/noid/add-bulk-activity

Conversation

@miaulalala

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

TODO

  • ...

Checklist

@st3inyst3iny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

Comment threadlib/private/Activity/Manager.php
Comment threadlib/public/Activity/IManager.php Outdated
Comment threadlib/private/Activity/Manager.php Outdated
@miaulalala
miaulalala requested a review from st3inyAugust 5, 2025 16:49

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But fine in general from my side

Comment threadlib/private/Activity/Manager.php
Comment threadlib/public/Activity/IBulkConsumer.php Outdated
Comment threadlib/public/Activity/IManager.php
@st3iny

st3iny commented Aug 11, 2025

Copy link
Copy Markdown
Member

@miaulalala Some test failures seem to be related:

1) Test\Activity\ManagerTest::testPublish with data set #0 (null, '')
OCP\Activity\Exceptions\IncompleteActivityException: The given event is invalid
/home/runner/actions-runner/_work/server/server/lib/private/Activity/Manager.php:113
/home/runner/actions-runner/_work/server/server/tests/lib/Activity/ManagerTest.php:244
2) Test\Activity\ManagerTest::testPublish with data set #1 ('test_author', 'test_author')
OCP\Activity\Exceptions\IncompleteActivityException: The given event is invalid
/home/runner/actions-runner/_work/server/server/lib/private/Activity/Manager.php:113
/home/runner/actions-runner/_work/server/server/tests/lib/Activity/ManagerTest.php:244

@st3iny

Copy link
Copy Markdown
Member

Looking good now. Squash and merge? :)

@miaulalala
miaulalalaforce-pushed the feat/noid/add-bulk-activity branch from b5a4916 to 2acd492CompareAugust 13, 2025 11:30
@st3iny
st3inyforce-pushed the feat/noid/add-bulk-activity branch from 2acd492 to 2e628e5CompareAugust 13, 2025 18:13
@st3inyst3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 14, 2025
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
miaulalalaforce-pushed the feat/noid/add-bulk-activity branch from 2e628e5 to 6a3a244CompareAugust 14, 2025 09:31
@miaulalala
miaulalala merged commit 1a2d0d5 into masterAug 14, 2025
242 of 250 checks passed
@miaulalala
miaulalala deleted the feat/noid/add-bulk-activity branch August 14, 2025 13:53
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: activity and notificationperformance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@miaulalala@st3iny@nickvergessen@skjnldsv