Skip to content

Remove XML header and line breaks in SVG files. - #5423

Merged
MorrisJobke merged 1 commit into
masterfrom
better-svg-optimization
Jun 17, 2017
Merged

Remove XML header and line breaks in SVG files.#5423
MorrisJobke merged 1 commit into
masterfrom
better-svg-optimization

Conversation

@pixelipo

Copy link
Copy Markdown
Contributor

My suggestion for further SVG optimiztion - as mentioned in #5229

Signed-off-by: Marin Treselj marin@pixelipo.com

My suggestion for further SVG optimiztion - as mentioned in #5229
Signed-off-by: Marin Treselj <marin@pixelipo.com>
@pixelipopixelipo added 3. to review Waiting for reviews design Design, UI, UX, etc. labels Jun 15, 2017
@pixelipopixelipo changed the title Remove XML heared and line breaks in SVG files.Remove XML header and line breaks in SVG files.Jun 15, 2017
@jancborchardt

Copy link
Copy Markdown
Member

Looks good! :) cc @nextcloud/designers for review.

@MorrisJobkeMorrisJobke added this to the Nextcloud 13 milestone Jun 17, 2017
@MorrisJobke
MorrisJobke merged commit 38cf9b8 into masterJun 17, 2017
@MorrisJobke
MorrisJobke deleted the better-svg-optimization branch June 17, 2017 23:35
@skjnldsv

Copy link
Copy Markdown
Member

Could be great to reoptimize all of them now that this is implemented! :)
Nice addition @pixelipo 👍

@jancborchardt

Copy link
Copy Markdown
Member

@skjnldsv before we do that we should revert the SVGO optimization though since it broke lots of icons ;) #4076 – then afterwards we can compress with Scour.

@pixelipopixelipo mentioned this pull request Sep 21, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsdesignDesign, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@pixelipo@jancborchardt@skjnldsv@MorrisJobke@juliusknorr