Skip to content

fix(trash): Fix order of metadata deletion - #54275

Merged
CarlSchwan merged 1 commit into
masterfrom
fix-order-metadata-deletion
Aug 7, 2025
Merged

fix(trash): Fix order of metadata deletion#54275
CarlSchwan merged 1 commit into
masterfrom
fix-order-metadata-deletion

Conversation

@CarlSchwan

@CarlSchwanCarlSchwan commented Aug 6, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Partially fix#54274

Summary

First query metadata for live photo and then delete the metadata, by making the SyncLivePhotosListener priority higher than the default.

Order of query before:

image

Order of query after:

image

Checklist

@CarlSchwan
CarlSchwan requested a review from a team as a code ownerAugust 6, 2025 12:27
@CarlSchwan
CarlSchwan requested review from ArtificialOwl, artonge, come-nc and salmart-dev and removed request for a teamAugust 6, 2025 12:27
@CarlSchwan
CarlSchwanforce-pushed the fix-order-metadata-deletion branch from 3b26682 to ff6d8b0CompareAugust 6, 2025 12:31
@CarlSchwanCarlSchwan mentioned this pull request Aug 6, 2025
Closed
@susnuxsusnux added this to the Nextcloud 32 milestone Aug 6, 2025
@susnuxsusnux added bug 3. to review Waiting for reviews labels Aug 6, 2025
@CarlSchwanCarlSchwan self-assigned this Aug 6, 2025
@CarlSchwan
CarlSchwanforce-pushed the fix-order-metadata-deletion branch from ff6d8b0 to ad8efbcCompareAugust 6, 2025 14:40
come-nc
come-nc reviewed Aug 7, 2025
View reviewed changes

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment above the registration explaining why would be good

Carl Schwan
fix(trash): Fix order of metadata deletion
9fef97c
First query metadata for live photo and then delete the metadata, by
making the SyncLivePhotosListener priority higher than the default.
Partially fix#54274
Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>
@CarlSchwan
CarlSchwanforce-pushed the fix-order-metadata-deletion branch from ad8efbc to 9fef97cCompareAugust 7, 2025 09:19
@CarlSchwan

CarlSchwan commented Aug 7, 2025

Copy link
Copy Markdown
MemberAuthor

A comment above the registration explaining why would be good

done

@CarlSchwan
CarlSchwan merged commit 43aa92f into masterAug 7, 2025
196 checks passed
@CarlSchwan
CarlSchwan deleted the fix-order-metadata-deletion branch August 7, 2025 13:04
@CarlSchwan

CarlSchwan commented Aug 7, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@CarlSchwan

CarlSchwan commented Aug 7, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@backportbotbackportbotBot mentioned this pull request Aug 7, 2025
Merged
@backportbotbackportbotBot mentioned this pull request Aug 7, 2025
Merged
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Merged
@github-actions

github-actionsBot commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev is a code owner automatically assigned from nextcloud/server-backend
@artongeartongeAwaiting requested review from artonge

Assignees

@CarlSchwanCarlSchwan

Labels

3. to reviewWaiting for reviewsbugfeedback-requested

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

Un-optimized and buggy deletion of metadata

4 participants

@CarlSchwan@susnux@come-nc@skjnldsv