Uh oh!
There was an error while loading. Please reload this page.
[stable12] Allow to find local users by their email address - #5428
Conversation
Allow to find local users by their email address Signed-off-by: Joas Schilling <coding@schilljs.com> Make sure to only add system users once Signed-off-by: Joas Schilling <coding@schilljs.com> Add unit test Signed-off-by: Joas Schilling <coding@schilljs.com>
| if (isset($contact['isLocalSystemBook'])) { | ||
| if ($exactEmailMatch) { | ||
| $cloud = $this->cloudIdManager->resolveCloudId($contact['CLOUD'][0]); |
There was a problem hiding this comment.
This addition led to a crash on my NC instance: users cannot share anymore with users with an email address set in NC.
For user "pab", with an email address, $contact['CLOUD'][0] resolves to "pab@" and resolveCloudId fails saying: Invalid cloud id.
See here for full error stack: https://help.nextcloud.com/t/cant-share-to-a-local-user/12339/4?u=pab
There was a problem hiding this comment.
Can someone tell me where the ['CLOUD'][0] value is supposed to be found? Is there a doc of the contactsManager to see to which fields of the database CLOUD shall be linked to?
There was a problem hiding this comment.
cc @nickvergessen this is where this weird share name could come from
Backport of #5384 to stable12
Works also with LDAP users btw. Just cherry-picked, did not need to touch code → 👍 from me