Uh oh!
There was an error while loading. Please reload this page.
fix(files_sharing): Implement conditional federation placeholder - #54310
Merged
Conversation
nfebeforce-pushed
the
fix/conditional-federation-placeholders
branch
from
August 7, 2025 05:45
be53ba4 to
0644472Comparenfebe
requested review from
ArtificialOwl, provokateurin, salmart-dev and sorbaugh
and removed request for
a team, ArtificialOwl, salmart-dev, simonschaufi and sorbaughAugust 7, 2025 05:45
skjnldsv
approved these changes
Aug 7, 2025
szaimen
removed their request for review
August 11, 2025 11:50
nfebeforce-pushed
the
fix/conditional-federation-placeholders
branch
from
August 11, 2025 16:35
0644472 to
a5878c8Comparenfebe
commented
Aug 11, 2025
ContributorAuthor
/compile |
nfebe
commented
Aug 11, 2025
ContributorAuthor
/backport to stable31 |
nfebe
commented
Aug 11, 2025
ContributorAuthor
/backport to stable30 |
nfebeforce-pushed
the
fix/conditional-federation-placeholders
branch
from
August 11, 2025 17:03
06fb629 to
5e2f125Comparenfebe
commented
Aug 11, 2025
ContributorAuthor
/compile |
nfebe
enabled auto-merge
August 11, 2025 17:03
This commits addresses an annoyance where the share input placeholder would suggest sharing via federated cloud ID even if federation was disabled. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebeforce-pushed
the
fix/conditional-federation-placeholders
branch
from
August 11, 2025 17:55
8674e92 to
e7f4de6Comparenfebe
commented
Aug 11, 2025
ContributorAuthor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
come-nc
reviewed
Aug 14, 2025
Comment on lines
280
to
282
| } | ||
| return this.config.showFederatedSharesAsInternal | ||
| return !this.config.showFederatedSharesAsInternal && !this.config.isFederationEnabled | ||
| ? t('files_sharing', 'Email') | ||
| : t('files_sharing', 'Email, federated cloud ID') |
Contributor
There was a problem hiding this comment.
This change looks suspicious.
I would have expected this.config.showFederatedSharesAsInternal || !this.config.isFederationEnabled?
@nfebe
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commits addresses an annoyance where the share input placeholder would suggest sharing via federated cloud ID even if federation was disabled.