Uh oh!
There was an error while loading. Please reload this page.
fix(files): drop usage of FileInfoModel - #54337
Merged
Merged
Conversation
skjnldsv
requested review from
nfebe, sorbaugh and susnux
and removed request for
a teamAugust 8, 2025 13:13
MemberAuthor
/backport c100369 to stable31 |
sorbaugh
approved these changes
Aug 8, 2025
susnux
reviewed
Aug 8, 2025
Uh oh!
There was an error while loading. Please reload this page.
susnux
approved these changes
Aug 10, 2025
susnux
commented
Aug 10, 2025
Contributor
/compile rebase |
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
fix/legacyView
branch
from
August 10, 2025 17:47
2e49762 to
9ce1066Compareskjnldsv
enabled auto-merge
August 11, 2025 08:13
Uh oh!
There was an error while loading. Please reload this page.
Merged
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OCA.Files.FileInfoModelhave been removed since 31The only place I could find a usage of `registerSecondaryView is in talk, and they're not even using the fileInfo here
https://github.com/nextcloud/spreed/blob/d01c35b1de3783f3ba45fef6eb90a6015a9b58b0/src/mainFilesSidebarLoader.js#L40
https://github.com/nextcloud/spreed/blob/e3d5161cf76260624d9cbae19fe043adc95de691/src/FilesSidebarCallViewApp.vue#L160-L161
I think we can safely remove it.
This is not an official API anyway, this was just a countermeasure when we were still trying to draft a proper Sidebar API
Should be cleared with the new Sidebar at some point