Uh oh!
There was an error while loading. Please reload this page.
fix: increase how long we cache display names - #54357
Merged
Merged
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
come-nc, nfebe and salmart-dev
and removed request for
a teamAugust 11, 2025 09:21
susnux
approved these changes
Aug 11, 2025
salmart-dev
approved these changes
Aug 11, 2025
Uh oh!
There was an error while loading. Please reload this page.
icewind1991
commented
Aug 11, 2025
MemberAuthor
/backport to stable31 |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since display names rarely change and we already listen to internal changes, it should be fine to cache them for a day.