Uh oh!
There was an error while loading. Please reload this page.
fix: catch and log exception from share events - #54419
Merged
Merged
Conversation
icewind1991
requested review from
ArtificialOwl, CarlSchwan and nfebe
and removed request for
a teamAugust 14, 2025 09:13
susnux
reviewed
Aug 14, 2025
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
share-event-catch
branch
from
August 14, 2025 09:37
1dad6ce to
dcc6c19Comparecome-nc
reviewed
Aug 14, 2025
come-nc
left a comment
Contributor
There was a problem hiding this comment.
Why have this specifically for share events?
This is the case for any event, any listener can crash the request.
So I’d say either we have that in the dispatcher or we do not have it at all?
icewind1991
commented
Aug 14, 2025
MemberAuthor
"Exceptions from events" seem to be used in at least some places |
CarlSchwan
approved these changes
Aug 14, 2025
susnux
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of failing the rest of the request, just log and move on.
Don't let something like nextcloud/activity#2103 stop people from leaving shares without seeing error messages.