Uh oh!
There was an error while loading. Please reload this page.
Add white version of the calendar.svg icon - #5447
Conversation
There's no reason for not including it and it is needed for Deck app. Signed-off-by: Marin Treselj <marin@pixelipo.com>
jancborchardt
left a comment
There was a problem hiding this comment.
We need to keep the viewbox attribute though, so all icon resizing in the apps menu and app management works on Firefox, right? cc @MorrisJobke
pixelipo
commented
Jun 16, 2017
@jancborchardt then what about core/img/places/files-dark.svg ? |
Codecov Report
@@ Coverage Diff @@## master #5447 +/- ##
============================================
- Coverage 54.14% 54.13% -0.01%
Complexity 22329 22329 ============================================
Files 1380 1380 Lines 85544 85544 Branches 1329 1329 ============================================
- Hits 46314 46311 -3 - Misses 39230 39233 +3
|
MorrisJobke
commented
Jun 16, 2017
Correct
Please add it there as well. We had weird rendering issues in firefox, especially if the view box is not there and the path is defined in a bigger scope, then firefox misrendered it |
Also removed some unneeded style declarations. Signed-off-by: Marin Treselj <marin@pixelipo.com>
pixelipo
commented
Jun 17, 2017
Ok, now all the places icons (apart from |
juliusknorr
commented
Jun 17, 2017
We should also introduce a class icon-calendar like there is one for icon-calendar-dark already. |
Signed-off-by: Marin Treselj <marin@pixelipo.com>
jancborchardt
commented
Jun 19, 2017
Failures unrelated, merging. :) |
There's no reason for not including it and it is needed for Deck app in nextcloud/deck#189
@nextcloud/designers @juliushaertl
Signed-off-by: Marin Treselj marin@pixelipo.com