Uh oh!
There was an error while loading. Please reload this page.
[stable30] fix(comments): use showFile route to reference files with a matching … - #54828
Merged
Conversation
backportbotBot
requested review from
AndyScherzinger, kesselb and provokateurinSeptember 3, 2025 09:42
kesselbforce-pushed
the
backport/54826/stable30
branch
from
September 3, 2025 10:03
0b29fe4 to
362f9cdCompareContributor
Conflicts: Psalm baseline (we are less strict in stable30 hence the deprecations are missing). |
kesselb
marked this pull request as ready for review
September 3, 2025 10:04
| return new SearchResultEntry( | ||
| $link = $this->urlGenerator->linkToRoute( | ||
| 'files.View.showFile', | ||
| ['fileid' => $result->fileId] |
Check notice
Code scanning / Psalm
DeprecatedProperty Note
Uh oh!
There was an error while loading. Please reload this page.
| $this->authorName = $authorName; | ||
| $this->fileName = basename($path); | ||
| $this->path = $this->getVisiblePath($path); | ||
| $this->fileId = $fileId; |
Check notice
Code scanning / Psalm
DeprecatedProperty Note
provokateurin
approved these changes
Sep 3, 2025
…comment The files.view.index route with dir and scrollto is deprecated and opening the actual does not work anymore. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselbforce-pushed
the
backport/54826/stable30
branch
from
September 3, 2025 10:16
362f9cd to
e390c82Comparekesselb
approved these changes
Sep 3, 2025
| '', | ||
| true | ||
| ); | ||
| $searchResultEntry->addAttribute('fileId', (string) $result->fileId); |
Check notice
Code scanning / Psalm
DeprecatedProperty Note
AndyScherzinger
enabled auto-merge
September 3, 2025 11:22
AndyScherzinger
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #54826
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.