Uh oh!
There was an error while loading. Please reload this page.
[stable31] fix(files_sharing): use newPassword always for the unsaved password - #55073
Merged
Conversation
susnux
requested review from
a team, Antreesy, nfebe, salmart-dev, sorbaugh and szaimen
and removed request for
a teamSeptember 12, 2025 10:04
susnux
commented
Sep 12, 2025
ContributorAuthor
/backport to stable32 |
susnux
commented
Sep 12, 2025
ContributorAuthor
/backport to master |
Antreesy
approved these changes
Sep 12, 2025
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Tested, looks good code-wise
`newPassword` is the unsaved password, while `share.password` is the current saved password. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/files-sharing-password
branch
from
September 12, 2025 10:13
e95fadb to
ee97330Comparesusnux
commented
Sep 12, 2025
ContributorAuthor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Sep 12, 2025
This was referenced Sep 16, 2025
8 tasks
mpivchev
commented
Sep 24, 2025
Is this patchable? Since it's vue and frontend? I am not sure |
susnux
commented
Sep 24, 2025
ContributorAuthor
@mpivchev not really, best to wait for the release on October 9, 2025 |
skjnldsv
commented
Nov 7, 2025
Member
Regression fix in #56278 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newPasswordis the unsaved password, whileshare.passwordis the current saved password.Checklist