Skip to content

fix(cache): Ensure unique global prefix per instanceid - #55383

Merged
susnux merged 1 commit into
masterfrom
fix/noid/unique-cache-prefix-per-instanceid
Sep 28, 2025
Merged

fix(cache): Ensure unique global prefix per instanceid#55383
susnux merged 1 commit into
masterfrom
fix/noid/unique-cache-prefix-per-instanceid

Conversation

@SystemKeeper

@SystemKeeperSystemKeeper commented Sep 28, 2025

Copy link
Copy Markdown
Contributor

Summary

  • Have 2 Nextcloud instances using the same PHP-FPM pool
  • Ensure that both instances have the same version / apps
  • Try to query capabilities, that are unique to both instance (e.g. talk signaling key)

Before this PR:
It's possible that instance 1 returns the key from instance 2 or vice versa

After this PR:
Key is correctly returned

Checklist

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
SystemKeeperforce-pushed the fix/noid/unique-cache-prefix-per-instanceid branch from 934e0ca to 34a085dCompareSeptember 28, 2025 15:59
@SystemKeeperSystemKeeper added 3. to review Waiting for reviews feature: caching Related to our caching system: scssCacher, jsCombiner... labels Sep 28, 2025
@SystemKeeperSystemKeeper added this to the Nextcloud 33 milestone Sep 28, 2025
@SystemKeeper

Copy link
Copy Markdown
ContributorAuthor

/backport to stable32

@fancycode

Copy link
Copy Markdown
Member

Thanks, after applying the patch I can no longer reproduce the problem I had without it.

@SystemKeeper
SystemKeeper marked this pull request as ready for review September 28, 2025 16:32
@SystemKeeper
SystemKeeper requested a review from a team as a code ownerSeptember 28, 2025 16:32
@SystemKeeper
SystemKeeper requested review from icewind1991, leftybournes and yemkareems and removed request for a teamSeptember 28, 2025 16:32

@fancycodefancycode left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@susnux
susnux merged commit 496d497 into masterSep 28, 2025
213 of 217 checks passed
@susnux
susnux deleted the fix/noid/unique-cache-prefix-per-instanceid branch September 28, 2025 17:07
@backportbot

Copy link
Copy Markdown

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/55383/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 34a085d3
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55383/stable32

Error: Failed to push branch backport/55383/stable32: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."}
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux

Copy link
Copy Markdown
Contributor

/backport to stable32

@nursoda

Copy link
Copy Markdown

Backlink to the same issue described in the forum.

@melroy89

Copy link
Copy Markdown
Contributor

/backport to stable32

Yes please.

@SystemKeeper

Copy link
Copy Markdown
ContributorAuthor

Yes please.

Already done :) the quote is a command to trigger the backport (#55386). It’s already merged and will be included in the next release

@melroy89

Copy link
Copy Markdown
Contributor

Yes please.

Already done :) the quote is a command to trigger the backport (#55386). It’s already merged and will be included in the next release

Thank you so much 🥇 .. Hopefully I can switch back to APCu again then

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsfeature: cachingRelated to our caching system: scssCacher, jsCombiner...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@SystemKeeper@fancycode@susnux@nursoda@melroy89@nickvergessen