Uh oh!
There was an error while loading. Please reload this page.
fix(files_sharing): Only send password on change - #55580
Merged
Merged
Conversation
nfebe
commented
Oct 6, 2025
ContributorAuthor
/backport to stable32 |
nfebe
commented
Oct 6, 2025
ContributorAuthor
/backport to stable31 |
susnux
approved these changes
Oct 6, 2025
susnux
left a comment
Contributor
There was a problem hiding this comment.
Code makes sense but did not test it
artonge
approved these changes
Oct 16, 2025
artonge
left a comment
Collaborator
There was a problem hiding this comment.
Looks good beside nitpick.
Uh oh!
There was an error while loading. Please reload this page.
nfebeforce-pushed
the
fix/share-permissions-password-validation
branch
from
October 20, 2025 13:55
a9b74c0 to
425d455Comparenfebe
commented
Oct 20, 2025
ContributorAuthor
/compile |
nfebe
enabled auto-merge
October 20, 2025 13:55
nfebeforce-pushed
the
fix/share-permissions-password-validation
branch
from
October 20, 2025 15:52
b1799aa to
5d726aaComparenfebe
commented
Oct 20, 2025
ContributorAuthor
/compile |
nfebeforce-pushed
the
fix/share-permissions-password-validation
branch
from
October 20, 2025 15:59
5d726aa to
7b31bf1Comparenfebe
commented
Oct 20, 2025
ContributorAuthor
/compile |
The password param should never be sent if the intention is not remove it or update it. This commit adapts the frontend and backend to this rule to avoid weird bugs especially around updating new shares. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebeforce-pushed
the
fix/share-permissions-password-validation
branch
from
October 21, 2025 15:55
06eaddc to
a28834bComparenfebe
commented
Oct 21, 2025
ContributorAuthor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
nfebe
commented
Oct 24, 2025
ContributorAuthor
/backport to stable32 |
nfebe
commented
Oct 24, 2025
ContributorAuthor
/backport to stable31 |
This was referenced Oct 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The password param should never be sent if the intention is not remove it or update it.
This commit adapts the frontend and backend to this rule to avoid weird bugs especially around updating new shares.