Skip to content

fix(dav): dav:remove-invalid-shares removing federated calendar shares - #55628

Merged
st3iny merged 1 commit into
masterfrom
fix/dav/remove-invalid-shares-federated-cal-shares
Oct 20, 2025
Merged

fix(dav): dav:remove-invalid-shares removing federated calendar shares#55628
st3iny merged 1 commit into
masterfrom
fix/dav/remove-invalid-shares-federated-cal-shares

Conversation

@st3iny

@st3inyst3iny commented Oct 8, 2025•
edited
Loading

Copy link
Copy Markdown
Member
  • Resolves: none

Summary

The command removes valid federated calendar shares as it is not able to find remote user principals.

Checklist

@st3inyst3iny added this to the Nextcloud 33 milestone Oct 8, 2025
@st3inyst3iny self-assigned this Oct 8, 2025
@st3iny
st3iny requested a review from a team as a code ownerOctober 8, 2025 15:10
@st3iny
st3iny requested review from Altahrim, nfebe and yemkareems and removed request for a teamOctober 8, 2025 15:10
@st3inyst3iny added bug 3. to review Waiting for reviews labels Oct 8, 2025
@st3iny

st3iny commented Oct 8, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable32

@st3iny
st3inyforce-pushed the fix/dav/remove-invalid-shares-federated-cal-shares branch from a9227d3 to c1fe635CompareOctober 14, 2025 10:09
@st3iny
st3iny enabled auto-merge October 14, 2025 10:18
@st3inyst3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 14, 2025
@AndyScherzinger
AndyScherzingerforce-pushed the fix/dav/remove-invalid-shares-federated-cal-shares branch from c1fe635 to 3c580ebCompareOctober 16, 2025 21:09
@st3iny

st3iny commented Oct 17, 2025

Copy link
Copy Markdown
MemberAuthor

Tests are indeed broken due to my changes. I'm on it.

@st3iny
fix(dav): dav:remove-invalid-shares removing federated calendar shares
3813a77
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny
st3inyforce-pushed the fix/dav/remove-invalid-shares-federated-cal-shares branch from 3c580eb to 3813a77CompareOctober 17, 2025 10:10
@st3iny
st3iny merged commit 4c17229 into masterOct 20, 2025
253 of 266 checks passed
@st3iny
st3iny deleted the fix/dav/remove-invalid-shares-federated-cal-shares branch October 20, 2025 11:19
@github-project-automationgithub-project-automationBot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware teamOct 20, 2025
@backportbotbackportbotBot mentioned this pull request Oct 20, 2025
Merged
@github-actions

github-actionsBot commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@nextcloud-botnextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@SebastianKrupinskiSebastianKrupinskiSebastianKrupinski approved these changes
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend
@yemkareemsyemkareemsAwaiting requested review from yemkareemsyemkareems is a code owner automatically assigned from nextcloud/server-backend

Assignees

@st3inyst3iny

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: caldavRelated to CalDAV internalsfeature: davfeature: federationfeedback-requested

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

3 participants

@st3iny@ChristophWurst@SebastianKrupinski