Skip to content

fix(ocm): format notifications - #55634

Merged
ArtificialOwl merged 1 commit into
masterfrom
fix/noid/ocm-value-format
Oct 16, 2025
Merged

fix(ocm): format notifications#55634
ArtificialOwl merged 1 commit into
masterfrom
fix/noid/ocm-value-format

Conversation

@ArtificialOwl

@ArtificialOwlArtificialOwl commented Oct 8, 2025

Copy link
Copy Markdown
Member
  • fix shareWith containing scheme of the remote instance
  • fix providerId to be a string when generating json

@ArtificialOwl
ArtificialOwlforce-pushed the fix/noid/ocm-value-format branch from 8cbf207 to 5e52d21CompareOctober 8, 2025 19:58
Comment threadapps/federatedfilesharing/lib/Notifications.php Outdated
@mickenordin
mickenordinforce-pushed the fix/noid/ocm-value-format branch 3 times, most recently from c622926 to a777cc5CompareOctober 10, 2025 11:07
@ArtificialOwl
ArtificialOwlforce-pushed the fix/noid/ocm-value-format branch from a777cc5 to 6b515a4CompareOctober 10, 2025 15:49

@mickenordinmickenordin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@ArtificialOwl
ArtificialOwl marked this pull request as ready for review October 13, 2025 14:15
@ArtificialOwl
ArtificialOwl requested review from Altahrim, CarlSchwan and yemkareems and removed request for a teamOctober 13, 2025 14:15
Comment threadapps/federatedfilesharing/lib/Notifications.php Outdated
@nickvergessennickvergessen added this to the Nextcloud 33 milestone Oct 13, 2025
@ArtificialOwl
ArtificialOwlforce-pushed the fix/noid/ocm-value-format branch from 6b515a4 to c0f900eCompareOctober 14, 2025 15:26
@ArtificialOwl

Copy link
Copy Markdown
MemberAuthor

@mickenordin let's have a first PR regarding string providerId

we'll check in the future if 'shareWith' is to be modified

@mickenordin

Copy link
Copy Markdown
Contributor

Lets go with what is currently here and worry about the rest later on

@ArtificialOwl

Copy link
Copy Markdown
MemberAuthor

/backport to stable32

@nickvergessen
nickvergessen dismissed their stale reviewOctober 16, 2025 11:56

Obsoleted by removing problematic parts

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
ArtificialOwlforce-pushed the fix/noid/ocm-value-format branch from 5c3ffed to b2a6c75CompareOctober 16, 2025 15:30
@ArtificialOwl
ArtificialOwl merged commit 7da7de8 into masterOct 16, 2025
215 of 221 checks passed
@ArtificialOwl
ArtificialOwl deleted the fix/noid/ocm-value-format branch October 16, 2025 21:17
@nextcloud-botnextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ArtificialOwl@mickenordin@nickvergessen@CarlSchwan