fix(ObjectStoreStorage): fix s3 path encoding (issue causing 55665)

[DaanSelen]

Credits go to: @frabe1579

• Resolves: [Bug]: Expected filesize of ... bytes but read with S3 storage and special characters #55665

Summary

Fixes the issue where the Nextcloud server is unable to parse the special characters to a s3 backend.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• [x ] Tests (unit, integration, api and/or acceptance) are included
• [x ] Screenshots before/after for front-end changes
• [x ] Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

I believe I filled it in right

[DaanSelen]

@provokateurin do you want me to get all checks to pass, or is approval of #55665 (comment)@frabe1579 enough?

[provokateurin]

We can ignore cypress failures here (as the PR is coming from a fork this is expected), but everything else needs to pass. Also a 2nd reviewer is needed.

[DaanSelen]

We can ignore cypress failures here (as the PR is coming from a fork this is expected), but everything else needs to pass. Also a 2nd reviewer is needed.

I believe the Block unconventional commits is fixed now with the title, is it not?

[provokateurin]

It's about the commit message, not the PR title. Also it should be more descriptive of the issue itself, so something like fix(ObjectStoreStorage): Encode original-path in writeStream should work.

[DaanSelen]

It's about the commit message, not the PR title. Also it should be more descriptive of the issue itself, so something like fix(ObjectStoreStorage): Encode original-path in writeStream should work.

Gotcha. Working on that.

[DaanSelen]

I have to manually patch this into customer nextcloud instances, are we getting closer to merging? And if not, what is holding us back?

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[DaanSelen]

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

I have no idea whats preventing merge.

[provokateurin]

Sorry, I was on vacation!

[provokateurin]

/backport to stable32

[provokateurin]

/backport to stable31

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[backportbot]

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/55717/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 4b4b39e7
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55717/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[provokateurin]

31 doesn't have this code, so no backport necessary and possible.

[DaanSelen]

Sorry, I was on vacation!

Hopefully you had a great time!

[lcppmd]

Hi,
Thanks for the patch.
I've rolled out manually and it is working perfectly.

[DaanSelen]

Hopefully its in the main Docker images soon!