Skip to content

fix(jobs): Limit command jobs to known cases - #55748

Merged
provokateurin merged 1 commit into
masterfrom
bugfix/noid/closure-job
Nov 4, 2025
Merged

fix(jobs): Limit command jobs to known cases#55748
provokateurin merged 1 commit into
masterfrom
bugfix/noid/closure-job

Conversation

@nickvergessen

@nickvergessennickvergessen commented Oct 14, 2025

Copy link
Copy Markdown
Member

Checklist

@nickvergessen
nickvergessen requested a review from a team as a code ownerOctober 14, 2025 11:57
@nickvergessen
nickvergessen requested review from CarlSchwan, provokateurin and sorbaugh and removed request for a teamOctober 14, 2025 11:57
@nickvergessennickvergessen added this to the Nextcloud 33 milestone Oct 14, 2025
@nickvergessennickvergessen self-assigned this Oct 14, 2025
@nickvergessennickvergessen added bug 3. to review Waiting for reviews labels Oct 14, 2025
@nickvergessen

nickvergessen commented Oct 14, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

/backport c0be533 to stable32

@nickvergessen

nickvergessen commented Oct 14, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

/backport c0be533 to stable31

@nickvergessen

nickvergessen commented Oct 14, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

/backport c0be533 to stable30

@nickvergessen

nickvergessen commented Oct 14, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

/backport c0be533 to stable29

@nickvergessen

nickvergessen commented Oct 14, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

/backport c0be533 to stable28

@miaulalala
miaulalalaforce-pushed the bugfix/noid/closure-job branch from c0be533 to 9767ecaCompareOctober 14, 2025 12:26
@nickvergessen
nickvergessen marked this pull request as draft October 14, 2025 13:11
@nickvergessen
fix(jobs): Limit command jobs to known cases
34f1ae6
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen changed the title fix(jobs): Fix parameter structure of ClosureJobfix(jobs): Limit command jobs to known casesNov 4, 2025
@nickvergessen
nickvergessen marked this pull request as ready for review November 4, 2025 10:34
@provokateurin
provokateurin merged commit 6911a33 into masterNov 4, 2025
208 of 214 checks passed
@provokateurin
provokateurin deleted the bugfix/noid/closure-job branch November 4, 2025 11:56
This was referenced Nov 4, 2025
Closed
Closed
Closed
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Jan 6, 2026
Merged
@skjnldsv

skjnldsv commented May 14, 2026•
edited
Loading

Copy link
Copy Markdown
Member

What's the right new approach to add a command in our apps then @nickvergessen ?
Ah, ok Symfony\Component\Console\Command\Command directly. Let me write some docs

server/lib/public/Command/ICommand.php

Line 13 in 54efa19

* @deprecated 33.0.0 The interface is considered internal going forward and should not be implemented by apps anymore

@nickvergessen

nickvergessen commented May 14, 2026

Copy link
Copy Markdown
MemberAuthor

No, the coding pattern is discouraged and should not be used. If you need a command to be executed make it a command with explicit setup instructions of your app.
Clonking background jobs is not the intended way

@skjnldsv

skjnldsv commented May 14, 2026

Copy link
Copy Markdown
Member

But was ICommand only reduced to background jobs?
Could I not register normal stuff like listing users with it ? (Random example)

Registering synchronous commands are still a proper acceptable pattern, right?

@skjnldsv

skjnldsv commented May 14, 2026

Copy link
Copy Markdown
Member

nextcloud/documentation#14853@nickvergessen

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@provokateurinprovokateurinprovokateurin approved these changes
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwanCarlSchwan is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@miaulalalamiaulalalaAwaiting requested review from miaulalala
@come-nccome-ncAwaiting requested review from come-nc

Assignees

@nickvergessennickvergessen

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen@skjnldsv@ChristophWurst@miaulalala@provokateurin@come-nc