Skip to content

fix(FilesPicker): Prevent selection of nodes without create permission - #55796

Merged
artonge merged 5 commits into
masterfrom
artonge/fix/hide_non_writable_nodes
Oct 22, 2025
Merged

fix(FilesPicker): Prevent selection of nodes without create permission#55796
artonge merged 5 commits into
masterfrom
artonge/fix/hide_non_writable_nodes

Conversation

@artonge

@artongeartonge commented Oct 15, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

It is misleading to show those nodes in the file picker, as picking them will always result in an error.

Todo:

The new version will also prevent navigation to non-readable folders. This will prevent navigating to E2EE folders.

BeforeAfter
imageScreenshot From 2025-10-17 11-17-19

@artonge
artonge requested review from a team and skjnldsv as code ownersOctober 15, 2025 14:50
@artonge
artonge requested review from sorbaugh and susnux and removed request for a teamOctober 15, 2025 14:50
@artongeartonge self-assigned this Oct 15, 2025
@artonge
artonge removed the request for review from sorbaughOctober 15, 2025 14:53
@artongeartonge added this to the Nextcloud 33 milestone Oct 15, 2025
@susnux

susnux commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

I think we discussed this somewhere with Jan, the outcome was that it is even more confusing to not see all your files.
The solution that was agreed is to grey out non-selectable files.

We probably need a second filter way for this on the library though...

@artonge

artonge commented Oct 15, 2025

Copy link
Copy Markdown
CollaboratorAuthor

We probably need a second filter way for this on the library though...

Or we instead gray out the files based on that already existing function? Is there a specific use case where we actually want to filter out some nodes?

@artongeartonge mentioned this pull request Oct 16, 2025
Merged
@artonge
artongeforce-pushed the artonge/fix/hide_non_writable_nodes branch from 9331209 to 37e2ebdCompareOctober 16, 2025 10:39
@artongeartonge mentioned this pull request Oct 16, 2025
Closed
susnux
susnux reviewed Oct 16, 2025
View reviewed changes
Comment threadapps/files/src/actions/moveOrCopyAction.ts Outdated
@artonge

artonge commented Oct 16, 2025

Copy link
Copy Markdown
CollaboratorAuthor

I don't think this will work.

We might not have create permission on a specific folder, but still have them on one of its subfolders. Groupfolders with ACLs for example.

So we still need to be able to navigate into those folders.
But for E2EE folders, it makes sense to not be able to navigate to them.

Maybe we also need a canNavigate function?

@susnux

susnux commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

But for E2EE folders, it makes sense to not be able to navigate to them.

Then you should be able to navigate into those greyed folder but not be able to pick them.
Thats all that this prop says: not pickable

@artonge

artonge commented Oct 17, 2025•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Then you should be able to navigate into those greyed folder but not be able to pick them.

No, for E2EE it does not make sense as we cannot even load their content. But luckily, they are also not readable, I'll push a better approach in a few minutes.

Edit: done

@artonge
artongeforce-pushed the artonge/fix/hide_non_writable_nodes branch from 37e2ebd to f2ab1c3CompareOctober 17, 2025 09:20
@artongeartonge changed the title fix(FilesPicker): Filter out non writable nodesfix(FilesPicker): Prevent selection of nodes without create permissionOct 17, 2025
@artonge
artongeforce-pushed the artonge/fix/hide_non_writable_nodes branch from f2ab1c3 to 9216214CompareOctober 17, 2025 10:36
@artonge
artonge requested a review from susnuxOctober 17, 2025 10:40
@artonge
artongeforce-pushed the artonge/fix/hide_non_writable_nodes branch 2 times, most recently from 3ffa65c to 35ec297CompareOctober 17, 2025 13:08
jancborchardt
jancborchardt approved these changes Oct 20, 2025
View reviewed changes

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Might additionally be good to have some textual support there, like a title on hover & focus which says "No permissions to upload to this folder", for example.

@artonge
artongeforce-pushed the artonge/fix/hide_non_writable_nodes branch from 35ec297 to 2f97714CompareOctober 21, 2025 15:14
@artonge
artonge requested a review from a team as a code ownerOctober 21, 2025 15:14
@artonge

artonge commented Oct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/compile /

@artonge

artonge commented Oct 21, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/compile rebase /

artongeand others added 5 commits October 21, 2025 20:27
@artonge@nextcloud-command
fix(FilesPicker): Prevent selection of nodes without create permission
cb062d2
And remove the disable callback for the button as it is not needed anymore.
This gives a better experience as the nodes do not have a pointer for cursor, and the submit button does not react when clicking on them.
Signed-off-by: Louis Chmn <louis@chmn.me>
@artonge@nextcloud-command
fix(FilePicker): Modernise dav imports
7b8463e
Signed-off-by: Louis Chmn <louis@chmn.me>
@artonge@nextcloud-command
chore(deps): Bump @nextcloud/dialogs to v7.1.0
58a9fda
Signed-off-by: Louis Chmn <louis@chmn.me>
@nextcloud-command
chore(assets): Recompile assets
c627561
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
chore(assets): Recompile assets
58e9be7
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-commandforce-pushed the artonge/fix/hide_non_writable_nodes branch from f45ef38 to 58e9be7CompareOctober 21, 2025 20:30
@artonge
artonge merged commit f2eb772 into masterOct 22, 2025
124 checks passed
@artonge
artonge deleted the artonge/fix/hide_non_writable_nodes branch October 22, 2025 05:18
@artonge

artonge commented Oct 22, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/backport cb062d2 to stable32

@artonge

artonge commented Oct 22, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/backport cb062d2 to stable31

@artonge

artonge commented Oct 22, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/backport cb062d2 to stable30

@backportbotbackportbotBot mentioned this pull request Oct 22, 2025
Merged
This was referenced Oct 22, 2025
Merged
Merged
@susnuxsusnux mentioned this pull request Nov 3, 2025
Open
8 tasks
@susnuxsusnux linked an issue Nov 3, 2025 that may be closed by this pull request
[Bug]: Remove files from the list of recent items in the move/copy modal #50199
Open
8 tasks
@artongeartonge mentioned this pull request Nov 6, 2025
Closed
9 tasks
@nextcloud-botnextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardtjancborchardtjancborchardt approved these changes
@susnuxsusnuxsusnux approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner
@kra-mokra-moAwaiting requested review from kra-mo

Assignees

@artongeartonge

Labels

3. to reviewWaiting for reviewsbugfeature: filesjavascript

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

[Bug]: Remove files from the list of recent items in the move/copy modal

4 participants

@artonge@susnux@jancborchardt@nextcloud-command