Uh oh!
There was an error while loading. Please reload this page.
fix(sharing): Allow public share access for everyone - #55811
Merged
Conversation
nfebe
requested review from
Altahrim, provokateurin and yemkareems
and removed request for
a teamOctober 16, 2025 13:55
nfebe added a commit
that referenced
this pull request
Oct 17, 2025
Following #55811 split `shareApiAllowLinks()` into two dedicated methods to improve clarity and separation of concerns: - `isLinkSharingEnabled()`: Checks if link sharing is globally enabled - `canUserCreateLinkShares()`: Checks if a user can create link shares (considers both global settings and group restrictions) The original shareApiAllowLinks() is now deprecated and acts as a wrapper to maintain backward compatibility.
artonge
reviewed
Oct 17, 2025
artonge
left a comment
Collaborator
There was a problem hiding this comment.
I think we should rather change the check to check whether the share owner can create links. This would allow preventing access to a share if the share owner is prevented to create links after it was created.
nfebeforce-pushed
the
fix/public-share-group-exclusion-access
branch
from
November 13, 2025 10:46
7a9c04a to
ea29e2fComparenfebeforce-pushed
the
fix/public-share-group-exclusion-access
branch
from
November 13, 2025 22:17
ea29e2f to
e222c83Compareprovokateurin
requested changes
Nov 17, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
juliusknorr
commented
Nov 19, 2025
Member
/backport to stable32 |
juliusknorr
commented
Nov 19, 2025
Member
/backport to stable31 |
juliusknorr
commented
Nov 19, 2025
Member
/backport to stable30 |
nfebeforce-pushed
the
fix/public-share-group-exclusion-access
branch
from
November 25, 2025 11:38
e222c83 to
ed0d841Comparenfebeforce-pushed
the
fix/public-share-group-exclusion-access
branch
from
November 25, 2025 11:40
ed0d841 to
5aa8a64Comparejuliusknorrforce-pushed
the
fix/public-share-group-exclusion-access
branch
from
November 27, 2025 07:53
5aa8a64 to
ca7755fComparejuliusknorr
approved these changes
Nov 27, 2025
provokateurin
requested changes
Dec 2, 2025
Uh oh!
There was an error while loading. Please reload this page.
When a logged-in user accesses a public share link in the same browser, the system was incorrectly checking if that user's groups were excluded from creating link shares. This caused share not found errors for users in excluded groups, even though public shares should be accessible to anyone with the link. The group exclusion setting (`shareapi_allow_links_exclude_groups`) is intended to restrict share creation, not share access. Public shares are meant to be anonymous and accessible regardless of the viewer identity or group membership. We now check the exclusion for the share creator and not the viewer. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebeforce-pushed
the
fix/public-share-group-exclusion-access
branch
from
December 2, 2025 08:45
ca7755f to
6bccaf7Compareprovokateurin
approved these changes
Dec 2, 2025
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Dec 2, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a logged-in user accesses a public share link in the same browser, the system was incorrectly checking if that user's groups were excluded from creating link shares. This caused share not found errors for users in excluded groups, even though public shares should be accessible to anyone with the link.
The group exclusion setting (
shareapi_allow_links_exclude_groups) is intended to restrict share creation, not share access. Public shares are meant to be anonymous and accessible regardless of the viewer identity or group membership.