Skip to content

feat(cloud-federation-api): accept folder shares - #55818

Merged
blizzz merged 2 commits into
masterfrom
feat/ocm-accept-folder-share
Nov 5, 2025
Merged

feat(cloud-federation-api): accept folder shares#55818
blizzz merged 2 commits into
masterfrom
feat/ocm-accept-folder-share

Conversation

@mickenordin

Copy link
Copy Markdown
Contributor

Normalize resourceType from folder to file in
RequestHandlerController::addShare() to allow accepting OCM folder shares from oCIS/OpenCloud/CERNBox.

@mickenordin
mickenordin requested a review from a team as a code ownerOctober 17, 2025 07:41
@mickenordin
mickenordin requested review from Altahrim and removed request for a teamOctober 17, 2025 07:41
@mickenordin
mickenordinforce-pushed the feat/ocm-accept-folder-share branch from 2ccd204 to 34f7fe7CompareOctober 17, 2025 11:50
@mickenordin
mickenordinforce-pushed the feat/ocm-accept-folder-share branch 2 times, most recently from a65727a to c5d222dCompareOctober 21, 2025 14:04
@mickenordin
mickenordinforce-pushed the feat/ocm-accept-folder-share branch from c5d222d to 326cffbCompareOctober 27, 2025 11:26
@blizzzblizzz added this to the Nextcloud 33 milestone Oct 27, 2025
@ArtificialOwl

Copy link
Copy Markdown
Member

I think it is cleaner to duplicate and create an entry for 'folder' to the provider:

$manager->addCloudFederationProvider('file',
'Federated Files Sharing',
function () use ($appContainer): CloudFederationProviderFiles {
return$appContainer->get(CloudFederationProviderFiles::class);
});

@mickenordin
mickenordinforce-pushed the feat/ocm-accept-folder-share branch from 975d94b to 7299a68CompareOctober 28, 2025 14:30
@mickenordin

Copy link
Copy Markdown
ContributorAuthor

I think it is cleaner to duplicate and create an entry for 'folder' to the provider:

$manager->addCloudFederationProvider('file',
'Federated Files Sharing',
function () use ($appContainer): CloudFederationProviderFiles {
return$appContainer->get(CloudFederationProviderFiles::class);
});

Is it better now @ArtificialOwl?

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@ArtificialOwl
ArtificialOwlforce-pushed the feat/ocm-accept-folder-share branch from 7299a68 to 67dc5efCompareNovember 5, 2025 16:15
Normalize resourceType from folder to file in
RequestHandlerController::addShare() to allow accepting
OCM folder shares from oCIS/OpenCloud/CERNBox.
Signed-off-by: Micke Nordin <kano@sunet.se>
Solve the problem by adding the provider for both files and folders
Signed-off-by: Micke Nordin <kano@sunet.se>
@mickenordin
mickenordinforce-pushed the feat/ocm-accept-folder-share branch from 67dc5ef to 4327093CompareNovember 5, 2025 19:24
@blizzz
blizzz merged commit 4328e28 into masterNov 5, 2025
227 of 235 checks passed
@blizzz
blizzz deleted the feat/ocm-accept-folder-share branch November 5, 2025 21:59
@nextcloudnextcloud deleted a comment from mickenordinNov 9, 2025
@ArtificialOwl

Copy link
Copy Markdown
Member

/backport to stable32

@nextcloud-botnextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mickenordin@ArtificialOwl@provokateurin@blizzz