Skip to content

fix(ocm-sharing): The owner needs to be set for sharing to work - #55827

Merged
nickvergessen merged 1 commit into
masterfrom
fix/ocm-owner-sharing
Oct 22, 2025
Merged

fix(ocm-sharing): The owner needs to be set for sharing to work#55827
nickvergessen merged 1 commit into
masterfrom
fix/ocm-owner-sharing

Conversation

@mickenordin

@mickenordinmickenordin commented Oct 17, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

The specification says that the display name is optional and can thus be empty, and in fact it is from oCIS and CERNBox shares.

The correct thing to set is the required opaque id from the remote provider, the owner which will always be there.

Moved here from #55752

@mickenordin
mickenordin requested a review from a team as a code ownerOctober 17, 2025 11:46
@mickenordin
mickenordin requested review from sorbaugh and removed request for a teamOctober 17, 2025 11:46
@mickenordin

mickenordin commented Oct 17, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable32

nickvergessen
nickvergessen reviewed Oct 17, 2025
View reviewed changes
Comment threadapps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php Outdated
@mickenordinmickenordin added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 21, 2025
@mickenordin
fix(ocm-sharing): The owner needs to be set for sharing to work
f7dcd1d
The specification says that the display name is optional and can thus
be empty, and in fact it is from oCIS and CERNBox shares.
The correct thing to set is the required opaque id from the remote
provider, the `owner` which will allways be there.
Signed-off-by: Micke Nordin <kano@sunet.se>
@nickvergessen
nickvergessen merged commit 00a6a73 into masterOct 22, 2025
187 checks passed
@nickvergessen
nickvergessen deleted the fix/ocm-owner-sharing branch October 22, 2025 08:26
@nickvergessen

nickvergessen commented Oct 22, 2025

Copy link
Copy Markdown
Member

/backport to stable32

@backportbotbackportbotBot mentioned this pull request Oct 22, 2025
Merged
@nextcloudnextcloud deleted a comment from backportbotBotOct 22, 2025
@AndyScherzingerAndyScherzinger added this to the Nextcloud 33 milestone Oct 22, 2025
@github-actions

github-actionsBot commented Nov 1, 2025

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@nextcloud-botnextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@AndyScherzingerAndyScherzingerAndyScherzinger approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwl
@provokateurinprovokateurinAwaiting requested review from provokateurin
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish32-feedbackbugfeedback-requested

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

3 participants

@mickenordin@nickvergessen@AndyScherzinger