Uh oh!
There was an error while loading. Please reload this page.
fix: join accounts_data instead of preferences when searching users - #55952
Merged
Conversation
skjnldsv
requested review from
icewind1991, salmart-dev and sorbaugh
and removed request for
a teamOctober 23, 2025 06:45
skjnldsvforce-pushed
the
fix/search-fallback
branch
from
October 23, 2025 06:51
6ca59f8 to
47a0313Compareskjnldsv
commented
Oct 23, 2025
MemberAuthor
/backport to stable31 |
skjnldsv
commented
Oct 23, 2025
MemberAuthor
/backport to stable32 |
skjnldsvforce-pushed
the
fix/search-fallback
branch
2 times, most recently
from
October 23, 2025 06:58
7dd9cbc to
08e9f3dCompareSigned-off-by: skjnldsv <skjnldsv@protonmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsvforce-pushed
the
fix/search-fallback
branch
from
October 23, 2025 06:59
08e9f3d to
89a2caeComparecome-nc
approved these changes
Oct 23, 2025
CarlSchwan
approved these changes
Oct 23, 2025
miaulalala
approved these changes
Oct 23, 2025
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Oct 23, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When searching for users in groups (user management > select a group > filter users top right), the
searchInGroupis used. Unfortunately this joining the users table, which LDAP or SAML users do not use.Joining the accounts_data table allows us better matches and makes us compatible with other users backends
Changes
group_user>users>preferencesgroup_user>accounts_datatwice (displaynameandemail)Checklist
3. to review, feature component)stable32)