Uh oh!
There was an error while loading. Please reload this page.
fix(encryption): Increment lastChunkNr when size is off - #55981
Merged
Conversation
lastChunkNr when size is offartonge
marked this pull request as ready for review
November 19, 2025 12:41
artonge
requested review from
leftybournes, provokateurin, salmart-dev and yemkareems
and removed request for
a teamNovember 19, 2025 12:41
artonge
commented
Nov 19, 2025
CollaboratorAuthor
/backport to stable32 |
artonge
commented
Nov 19, 2025
CollaboratorAuthor
/backport to stable31 |
provokateurin
approved these changes
Nov 19, 2025
When computing the unencrypted file size, we need the size of the last encrypted chunk as its size is usually not the regular 8192 bits. To avoid reading the whole file, we seek directly to that last chunk based on the expected file size. When the expected file size is smaller than the actual one, we have a logic in place to continue reading until we reach the end of the file. In that logic, we forgot to increment the `$lastChunkNr` which is important when we later check the signature of the chunk. This commit adds that missing increment. Signed-off-by: Louis Chmn <louis@chmn.me>
artongeforce-pushed
the
artonge/fix/encryption/increment_lastChunkNr
branch
from
November 21, 2025 16:34
10b8610 to
30d567fComparecome-nc
approved these changes
Nov 25, 2025
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Nov 25, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When computing the unencrypted file size, we need the size of the last encrypted chunk as its size is usually not the regular 8192 bits.
To avoid reading the whole file, we seek directly to that last chunk based on the expected file size. When the expected file size is smaller than the actual one, we have a logic in place to continue reading until we reach the end of the file.
In that logic, we forgot to increment the
$lastChunkNrwhich is important when we later check the signature of the chunk.This commit adds that missing increment.