Skip to content

Replace icon with outline variant - #56019

Merged
AndyScherzinger merged 2 commits into
masterfrom
style/noid/outlineShareExpiryIcon
Oct 27, 2025
Merged

Replace icon with outline variant#56019
AndyScherzinger merged 2 commits into
masterfrom
style/noid/outlineShareExpiryIcon

Conversation

@AndyScherzinger

@AndyScherzingerAndyScherzinger commented Oct 27, 2025

Copy link
Copy Markdown
Member
  • Resolves: see screenshot
    1024-2253

Summary

Share expiry icon has been missed to be replaced with the outline variant

TODO

  • backport to v32

Checklist

@AndyScherzingerAndyScherzinger added this to the Nextcloud 33 milestone Oct 27, 2025
@AndyScherzinger
AndyScherzinger requested a review from a team as a code ownerOctober 27, 2025 08:24
@AndyScherzingerAndyScherzinger added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: sharing labels Oct 27, 2025
@AndyScherzinger
AndyScherzinger requested review from artonge, kra-mo, sorbaugh and szaimen and removed request for a teamOctober 27, 2025 08:24

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
AndyScherzingerforce-pushed the style/noid/outlineShareExpiryIcon branch from 675cdc6 to 67b8be5CompareOctober 27, 2025 15:29
@AndyScherzinger

Copy link
Copy Markdown
MemberAuthor

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger
AndyScherzinger merged commit adc2012 into masterOct 27, 2025
134 of 137 checks passed
@AndyScherzinger
AndyScherzinger deleted the style/noid/outlineShareExpiryIcon branch October 27, 2025 18:11
@AndyScherzinger

Copy link
Copy Markdown
MemberAuthor

/backport 67b8be5 to stable32

@backportbot

Copy link
Copy Markdown

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/56019/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 67b8be59
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56019/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbackport-requestdesignDesign, UI, UX, etc.feature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@AndyScherzinger@CarlSchwan@szaimen@nextcloud-command