Skip to content

fix(files_external): check for changes when saving settings - #56042

Merged
enjeck merged 2 commits into
masterfrom
fix/55598
Nov 11, 2025
Merged

fix(files_external): check for changes when saving settings#56042
enjeck merged 2 commits into
masterfrom
fix/55598

Conversation

@enjeck

Copy link
Copy Markdown
Contributor

Summary

Fixes#55598

TODO

  • ...

Checklist

@enjeck
enjeck requested review from a team and skjnldsv as code ownersOctober 28, 2025 08:57
@enjeck
enjeck requested review from szaimen and removed request for a teamOctober 28, 2025 08:57

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there's a more elegant way of going about this.

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hacky, but for files_external I guess this is ok :)

@szaimen
szaimen requested review from artonge and susnux and removed request for artonge and szaimenOctober 31, 2025 13:16
@szaimenszaimen added this to the Nextcloud 33 milestone Oct 31, 2025
@enjeck
enjeckforce-pushed the fix/55598 branch 3 times, most recently from d9da142 to 141d62bCompareNovember 3, 2025 18:38
@enjeck

Copy link
Copy Markdown
ContributorAuthor

/backport to stable32

@enjeck

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

@juliusknorr

Copy link
Copy Markdown
Member

/compile

enjeckand others added 2 commits November 11, 2025 11:16
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@enjeck
enjeck merged commit a459f56 into masterNov 11, 2025
149 of 151 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: External storage prompts for password even without changes

7 participants

@enjeck@juliusknorr@susnux@artonge@leftybournes@szaimen@nextcloud-command