Uh oh!
There was an error while loading. Please reload this page.
refactor(comment): Port away from deprecated event comment constant - #56076
Merged
Conversation
CarlSchwanforce-pushed
the
carl/cleanup-comment
branch
2 times, most recently
from
October 29, 2025 10:22
ebdab58 to
6ec7466CompareCarlSchwanforce-pushed
the
carl/cleanup-comment
branch
from
November 24, 2025 16:26
6ec7466 to
21f4ce9CompareCarlSchwan
marked this pull request as ready for review
November 24, 2025 16:27
CarlSchwan
requested review from
Altahrim, leftybournes, salmart-dev and yemkareems
and removed request for
a teamNovember 24, 2025 16:27
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Create new events to replace deprecated CommentsEvent constant and use them when creating CommentsEvents. On the listener side, we can't yet use these events as deck still send the old events. Also fixes some issues reported by psalm level 3 on the comment app. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
CarlSchwanforce-pushed
the
carl/cleanup-comment
branch
from
December 4, 2025 16:38
21f4ce9 to
3c9b937CompareUh oh!
There was an error while loading. Please reload this page.
nickvergessen
approved these changes
Dec 5, 2025
ChristophWurst
approved these changes
Dec 5, 2025
Uh oh!
There was an error while loading. Please reload this page.
Merged
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create new events to replace deprecated CommentsEvent constant and use them when creating CommentsEvents.
On the listener side, we can't yet use these events as deck still send the old events.
Also fixes some issues reported by psalm level 3 on the comment app.
TODO
Checklist
3. to review, feature component)stable32)