Skip to content

fix(ldap): make base check case insensitive - #56080

Closed
hamza221 wants to merge 1 commit into
masterfrom
fix/ldap/case-insensitive-base
Closed

fix(ldap): make base check case insensitive#56080
hamza221 wants to merge 1 commit into
masterfrom
fix/ldap/case-insensitive-base

Conversation

@hamza221

@hamza221hamza221 commented Oct 29, 2025

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

TODO

  • ...

Checklist

@hamza221
fix(ldap): make base check case insensitive
2c0af45
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@hamza221
hamza221 requested a review from blizzzOctober 29, 2025 14:46
@hamza221hamza221 self-assigned this Oct 29, 2025
@hamza221
hamza221 requested a review from a team as a code ownerOctober 29, 2025 14:46
@hamza221hamza221 added the 3. to review Waiting for reviews label Oct 29, 2025
@hamza221
hamza221 requested review from ArtificialOwl, leftybournes, salmart-dev and yemkareems and removed request for a teamOctober 29, 2025 14:46
blizzz
blizzz requested changes Oct 29, 2025
View reviewed changes

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be mb_strtolower as it may contain non-ascii characters.

Imo we still should drop this added checks generally.

To be checked with @come-nc

@blizzz

blizzz commented Oct 30, 2025

Copy link
Copy Markdown
Member

obsoloted by #56085

@blizzzblizzz closed this Oct 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzzblizzzblizzz requested changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev is a code owner automatically assigned from nextcloud/server-backend
@yemkareemsyemkareemsAwaiting requested review from yemkareemsyemkareems is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

@hamza221hamza221

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hamza221@blizzz