Uh oh!
There was an error while loading. Please reload this page.
fix(encryption): Fix user key support with basic auth - #56167
Merged
Conversation
come-nc
requested review from
ArtificialOwl, icewind1991, leftybournes and salmart-dev
and removed request for
a teamNovember 3, 2025 16:41
8 tasks
come-nc
commented
Nov 3, 2025
ContributorAuthor
/backport to stable32 |
When using basic authentication the user is not logged in yet when KeyManager constructor gets called, so we need to delay the check for the loggedin user uid. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-ncforce-pushed
the
fix/fix-encryption-with-user-keys
branch
from
November 10, 2025 17:11
f1c87bd to
928a45cCompareblizzz
approved these changes
Nov 10, 2025
miaulalala
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using basic authentication the user is not logged in yet when KeyManager constructor gets called, so we need to delay the check for the loggedin user uid.
Checklist
3. to review, feature component)stable32)