Uh oh!
There was an error while loading. Please reload this page.
ci(psalm): Add a checker against logical operators - #56284
Merged
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
ArtificialOwl, icewind1991, salmart-dev and yemkareems
and removed request for
a teamNovember 7, 2025 11:09
nickvergessen
requested review from
ChristophWurst, come-nc, provokateurin and susnux
and removed request for
ArtificialOwl, icewind1991, salmart-dev and yemkareemsNovember 7, 2025 12:40
provokateurin
approved these changes
Nov 7, 2025
ChristophWurst
approved these changes
Nov 7, 2025
| public static function afterExpressionAnalysis(AfterExpressionAnalysisEvent $event): ?bool { | ||
| $stmt = $event->getExpr(); | ||
| if ($stmt instanceof PhpParser\Node\Expr\BinaryOp\LogicalAnd | ||
| || $stmt instanceof PhpParser\Node\Expr\BinaryOp\LogicalOr) { |
There was a problem hiding this comment.
Suggested change
| ||$stmtinstanceofPhpParser\Node\Expr\BinaryOp\LogicalOr) { | |
| or$stmtinstanceofPhpParser\Node\Expr\BinaryOp\LogicalOr) { |
/s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test run with manipulated code in Talk
Checklist
3. to review, feature component)stable32)