Uh oh!
There was an error while loading. Please reload this page.
Add rememberme checkbox - #56343
Merged
Merged
Conversation
come-nc
requested review from
icewind1991, nfebe, salmart-dev, sorbaugh and susnux
and removed request for
a teamNovember 10, 2025 13:12
come-nc
commented
Nov 10, 2025
ContributorAuthor
/compile / |
ChristophWurst
approved these changes
Nov 10, 2025
| ITrustedDomainHelper $trustedDomainHelper, | ||
| string $user = '', | ||
| string $password = '', | ||
| bool $rememberme = false, |
There was a problem hiding this comment.
Suggested change
| bool $rememberme = false, | |
| bool $remember_me = false, |
for consistency with the other parameters? not sure
ContributorAuthor
There was a problem hiding this comment.
That would force me to rename all the camelCase to rememberMe then for consistency 😒
come-ncforce-pushed
the
feat/add-rememberme-checkbox
branch
from
November 10, 2025 14:30
5bef2d7 to
6eb9804Comparecome-nc
commented
Nov 13, 2025
ContributorAuthor
/compile rebase |
sorbaugh
approved these changes
Nov 13, 2025
nextcloud-commandforce-pushed
the
feat/add-rememberme-checkbox
branch
from
November 13, 2025 09:31
6eb9804 to
bb22e56Comparesorbaugh
commented
Nov 13, 2025
Contributor
/backport to stable32 |
sorbaugh
commented
Nov 13, 2025
Contributor
/backport to stable31 |
come-nc
commented
Nov 13, 2025
ContributorAuthor
/compile rebase |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Only present if allowed by configuration. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
feat/add-rememberme-checkbox
branch
from
November 13, 2025 13:32
9a7744d to
907fb19Comparecome-nc
enabled auto-merge
November 13, 2025 14:55
sorbaugh
disabled auto-merge
November 13, 2025 15:53
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Nov 13, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a remember me checkbox to the login form.
Checklist
3. to review, feature component)stable32)