Skip to content

fix: pass only necessary information when deleting mulitple objects - #56366

Merged
sorbaugh merged 1 commit into
masterfrom
leftybournes/fix/s3_delete_folders
Nov 18, 2025
Merged

fix: pass only necessary information when deleting mulitple objects#56366
sorbaugh merged 1 commit into
masterfrom
leftybournes/fix/s3_delete_folders

Conversation

@leftybournes

@leftybournesleftybournes commented Nov 11, 2025

Copy link
Copy Markdown
Member

DeleteObjects currently fails when the request includes all the information returned by ListObjects. Send only the necessary information in the request. Note: 'Size' and 'DateModified' is now only supported by directory buckets.

Checklist

@leftybournesleftybournes added this to the Nextcloud 33 milestone Nov 11, 2025
@leftybournes
leftybournes requested a review from a team as a code ownerNovember 11, 2025 05:29
@leftybournesleftybournes added bug 3. to review Waiting for reviews labels Nov 11, 2025
@leftybournes
leftybournes requested review from CarlSchwan, come-nc, icewind1991 and salmart-dev and removed request for a teamNovember 11, 2025 05:29
@leftybournes
leftybournesforce-pushed the leftybournes/fix/s3_delete_folders branch from dc1b482 to eb44a50CompareNovember 11, 2025 05:31
@leftybournes

leftybournes commented Nov 12, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable32

@leftybournes

leftybournes commented Nov 12, 2025

Copy link
Copy Markdown
MemberAuthor

Backport to stable31 is not necessary as the issue only occurs with stable32, which uses a more recent aws sdk version causing the issue.

@leftybournes
leftybournesforce-pushed the leftybournes/fix/s3_delete_folders branch 2 times, most recently from e63824b to 08d1990CompareNovember 15, 2025 23:32
@provokateurinprovokateurin mentioned this pull request Nov 17, 2025
Closed
8 tasks
Kent Delante
fix: pass only necessary information when deleting mulitple objects
b57db10
DeleteObjects currently fails when the request includes all the
information returned by ListObjects. Send only the necessary
information in the request. Note: 'Size' and 'DateModified' is now
only supported by directory buckets.
Signed-off-by: Kent Delante <kent.delante@proton.me>
@leftybournes
leftybournesforce-pushed the leftybournes/fix/s3_delete_folders branch from 08d1990 to b57db10CompareNovember 18, 2025 04:07
@sorbaugh
sorbaugh disabled auto-merge November 18, 2025 08:47
@sorbaugh
sorbaugh merged commit ba9fe48 into masterNov 18, 2025
286 of 306 checks passed
@sorbaugh
sorbaugh deleted the leftybournes/fix/s3_delete_folders branch November 18, 2025 08:48
@backportbotbackportbotBot mentioned this pull request Nov 18, 2025
Merged
@sorbaugh

sorbaugh commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

/backport to stable32

@backportbot

backportbotBot commented Nov 18, 2025

Copy link
Copy Markdown

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/56366/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick b57db108
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56366/stable32

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/56366/stable32."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nextcloud-botnextcloud-bot mentioned this pull request Jan 6, 2026
Merged
@leftybournes

leftybournes commented Feb 11, 2026

Copy link
Copy Markdown
MemberAuthor

Backport to stable31 is not necessary as the issue only occurs with stable32, which uses a more recent aws sdk version causing the issue.

The issue started occurring with 31.0.13 so a backport is necessary now: #58255

@leftybournesleftybournes mentioned this pull request Feb 26, 2026
Merged
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AltahrimAltahrimAltahrim approved these changes
@provokateurinprovokateurinprovokateurin approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev is a code owner automatically assigned from nextcloud/server-backend
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwanCarlSchwan is a code owner automatically assigned from nextcloud/server-backend
@come-nccome-ncAwaiting requested review from come-nccome-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbackport-requestbug

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

[Bug]: Can't delete folders on external storage (S3)

4 participants

@leftybournes@sorbaugh@Altahrim@provokateurin